-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test (gbtest76) on Apple Silicon #90
Comments
I removed the tests except the Output on Linux (passing):
Output on Mac (failing):
So the problem seems to be computing |
It's not an error at all. Those differences are just round-off error. The complex multiply/add/etc can differ slightly on different compilers. I use "assert(err==0)" if it seems appropriate, and if those fail with err of 1e-16, or so, I just replace it with "assert (err < 1e-12)" say. |
I do all my code updates on the master branch, not on the stable branch. The stable branches don't get git commits very often, except for the next stable release. Can you make your PR's go to that branch instead? That would be a lot easier. Thanks! |
I just revised this test ; see the gbtest76.m in the master branch. |
Indeed, I should have targeted Thanks for revising the gbtest76 test case! I now tried running the Octave tests on 2682a3c but it failed due to a hard-coded x87 dependency in
Maybe |
Oops. That #if was supposed to guard against it but I wrote it wrong. See the next push on master. |
Thanks! It works now and the tests pass:
|
I made some progress on porting the library to Apple Silicon (#84, #86). This issue documents how to build Octave v7 on macOS and run the test. Finally, it contains the output of a single failing test.
Building Octave
Grab the brew formula:
Edit
octave.rb
"disable-docs"
toargs
(or ensure that you have a working texinfo installation).hg
) repository: switch from thedefault
branch (containing code for Octave v8.0) tostable
(v7.0).Run
This takes about 10 minutes.
Building the tests (gbmake)
Grab the OpenMP binaries as described at https://mac.r-project.org/openmp/:
Run
sed -i.bkp 's/-fopenmp/-Xclang -fopenmp/g' @GrB/private/gbmake.m
Run
octave
and follow the instructions inGraphBLAS/README.md
, includinggbmake
:Running the tests
Run the tests:
Currently, all tests pass except one.
Failing test: gbtest76
gbtest76
fails on macOS / Apple Silicon. (I tried running it in both Octave 7 and 8 on macOS. It passes on Linux with Octave 8. I did not try it on Linux with Octave 7.)The output of
gbtest76
is the following:Upon closer inspection, the only test case that fails is the following:
I printed the output before the assertion in line 432:
It indeed has a non-zero result:
The text was updated successfully, but these errors were encountered: