Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS to aarch64 platforms #84

Merged

Conversation

szarnyasg
Copy link
Contributor

@szarnyasg szarnyasg commented Dec 30, 2021

As I have remarked in #41 (comment), v6.1.1 works in Rosetta on Apple Silicon M1 CPUs.

Without Rosetta, make fails with the following error with both Clang and GCC:

$ make
...
[100%] Linking C executable list_cpu_features
Undefined symbols for architecture arm64:
  "_GetAarch64FeaturesEnumName", referenced from:
      _main in list_cpu_features.c.o
  "_GetAarch64FeaturesEnumValue", referenced from:
      _main in list_cpu_features.c.o
  "_GetAarch64Info", referenced from:
      _main in list_cpu_features.c.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

The solution is to apply the workaround suggested at google/cpu_features#211.
This PR makes this change.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 572c596 into DrTimothyAldenDavis:stable Jan 6, 2022
@szarnyasg szarnyasg deleted the m1-compatibility branch January 7, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants