Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

Change data type from string to Uri #413

Merged
merged 5 commits into from
Dec 25, 2021

Conversation

vanillajonathan
Copy link
Contributor

@vanillajonathan vanillajonathan commented Oct 13, 2021

Changes the data type from string to Uri.

Instead of weakly typed string we use strongly-typed Uri that accurately conveys the underlying data and ensures proper data and semantics through validation of input.

Closes #386.

@vanillajonathan
Copy link
Contributor Author

@leastprivilege I believe this CI might have failed because the Azure pipelines were down at that moment.
I think running it again would make the CI succeed.

@leastprivilege
Copy link
Contributor

Thanks. That's a breaking change. We can consider this for the next major release.

@leastprivilege
Copy link
Contributor

If you can resolve the conflicts today, I can put that into the v6 release

@vanillajonathan
Copy link
Contributor Author

@leastprivilege Done!

@leastprivilege leastprivilege merged commit 2c10f4b into DuendeArchive:main Dec 25, 2021
@leastprivilege
Copy link
Contributor

thanks!

@vanillajonathan vanillajonathan deleted the patch-1 branch December 25, 2021 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Uri instead of string datatype
2 participants