Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to Duende.Templates #640

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Conversation

khalidabuhakmeh
Copy link
Contributor

Description

This pull request updates all references from Duende.IdentityServer.Templates to the new Duende.Templates package. The changes include updates to NuGet links, source code references, and installation commands to ensure consistency across documentation and code.

@khalidabuhakmeh khalidabuhakmeh self-assigned this Mar 20, 2025
@khalidabuhakmeh khalidabuhakmeh added the documentation Improvements or additions to documentation label Mar 20, 2025
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-640.eastus2.azurestaticapps.net

bhazen
bhazen previously requested changes Mar 20, 2025
Copy link

@bhazen bhazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I'm marking this as requesting changes so we don't put the cart before the horse with updating docs before the new package is available

Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We may also want to explicitly call out that if you have the old version you should uninstall it.

Replaced all references from `Duende.IdentityServer.Templates` to the new `Duende.Templates` package. Updated NuGet links, source code references, and installation commands accordingly to ensure consistency across the documentation.
@khalidabuhakmeh khalidabuhakmeh force-pushed the ka-change-templates-package branch from e97232e to 96ccce0 Compare March 20, 2025 19:20
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-640.eastus2.azurestaticapps.net

Added instructions to uninstall previous versions of Duende templates and install the latest version. This ensures users have the most up-to-date templates for working with IdentityServer. Changes were applied to packaging, overview, and client credentials quickstart documents.
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-640.eastus2.azurestaticapps.net

Copy link
Member

@maartenba maartenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@bhazen bhazen dismissed their stale review March 27, 2025 18:14

Had only marked this "requested changes" to avoid publishing too early

@maartenba maartenba merged commit f791da1 into main Mar 28, 2025
2 of 3 checks passed
@maartenba maartenba deleted the ka-change-templates-package branch March 28, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants