Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix widget styling bugs #3065

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix widget styling bugs #3065

wants to merge 6 commits into from

Conversation

lenacohen
Copy link
Contributor

@lenacohen lenacohen commented Feb 27, 2025 •
edited
Loading

lenacohen
lenacohen commented Feb 27, 2025
View reviewed changes
src/js/contentscripts/socialwidgets.js Outdated
Comment on lines 406 to 409
let widgetFrame = document.createElement('iframe');
let shadowHost = document.createElement("div");
let shadowRoot = shadowHost.attachShadow({ mode: "closed" });
shadowRoot.appendChild(widgetFrame);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could replace the iframe with the shadowHost, but didn't see a benefit to doing that in the spirit of minimizing change. Let me know if you think I should.

@ghostwords ghostwords added the widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widget replacement overlapping with content on some sites
2 participants
@lenacohen @ghostwords