Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extensions.json #823

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ltrimino
Copy link

@ltrimino ltrimino commented Feb 6, 2025

Add Ryan Osullivan extension for LS-DYNA FEA code. MIT license in the Repo

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR introduces X change for Y reason.

Add Ryan Osullivan extension for LS-DYNA FEA code.
MIT license in the Repo
@filiptronicek
Copy link
Member

Hi @ltrimino 👋, looking at the logs, it seems that the extension doesn't build (I suspect something broke in the past 4 years since it was last pushed to).

If you can get the extension to build (either with our instructions in extensions.json or with manual commands, I'd be happy to build it myself and one-time publish it (we generally don't add extensions to the list that don't receive updates, because it's easier to just manually publish them once).

@filiptronicek filiptronicek added the changes-requested Waiting for an update label Feb 7, 2025
@ltrimino
Copy link
Author

ltrimino commented Feb 7, 2025

Hi @filiptronicek ,

thanks for giving it a go. I will see what I can do, fix that issue with the license and take a look at the manually building. BTW I do not see any set of particular instructions in the extensions. Json. Is there a wiki or some other document that I can look at?

@filiptronicek
Copy link
Member

@ltrimino the best place I can recommend for the structure of extension.json entries is either the JSON schema or better yet, other entries in the extensions.json file, which offer examples for the properties defined in the schema.

Because we're going to be one-time publishing this, I'll be happy to run commands to get it packaged on my end and published. No need to adhere to extensions.json, it would be enough to share in a PR comment.

@ltrimino
Copy link
Author

@filiptronicek I did took care of the license eca issue but I am at a lost as to how to build this thing. I was looking at both the json schema file and also the extensions.json file but it is not clear as to what needs to be done on my end. I did browse in the repository and there is a package.json ( https://github.com/osullivryan/vscode-lsdyna/blob/a2fa779b156e3d9cd31e12fa7a6ba326790adfe9/package.json ) file in the repository that maybe resembles what is needed for the build. Can you take a quick look and let me know if that is what you need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested Waiting for an update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants