pyln-client: reimplement NodeVersion, simply. #8143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
version-wtf
branch
from
cacd944 to
638b722
Compare
This broke my build machine, because lightningd --version was malformed (I had no tags somehow in that branch). I dived into the code to figure out what was wrong, and I was horrified. 1. STOP. Never write this much code. 2. You just need a NodeVersion class. That's it. No others. 3. Don't throw away the entire first part if it starts with 'v'. Just remove the v. 4. Always fail on invalid strings in the constructor, NOT on the first time you use it. I have rewritten it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
version-wtf
branch
from
638b722 to
22560d4
Compare
|
Concept ACK sad that this code was just landed 8e16cb1 :/ Anyway I agree, what we should do in the future is also simplify the CI we can not fail for just missing a changelog the entire CI like https://github.com/ElementsProject/lightning/actions/runs/13690706239/job/38283309786?pr=8143 What I expect is a bot message in the PR that tells you: "Hey we are defaulting this commit to Changelog-None, if you want to modify the changelog add Changelog-something: something". Anyhow I trust you and your code that is able to pass the Ci ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke my build machine, because lightningd --version was malformed (I had no tags somehow in that branch).
I dived into the code to figure out what was wrong, and I was horrified.
I have rewritten it.