Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puffin_viewer (v0.19) cargo install fails building on windows #193

Closed
Wumpf opened this issue Feb 14, 2024 · 6 comments
Closed

puffin_viewer (v0.19) cargo install fails building on windows #193

Wumpf opened this issue Feb 14, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Wumpf
Copy link

Wumpf commented Feb 14, 2024

Describe the bug

cargo install puffin_viewer currently fails building on windows:

error[E0432]: unresolved import `winapi::um::winuser`
   --> C:\Users\Andreas\.cargo\registry\src\index.crates.io-6f17d22bba15001f\eframe-0.25.0\src\native\app_icon.rs:83:9
    |
83  |     use winapi::um::winuser;
    |         ^^^^^^^^^^^^^^^^^^^ no `winuser` in `um`
    |
note: found an item that was configured out
   --> C:\Users\Andreas\.cargo\registry\src\index.crates.io-6f17d22bba15001f\winapi-0.3.9\src\um\mod.rs:290:37
    |
290 | #[cfg(feature = "winuser")] pub mod winuser;
    |                                     ^^^^^^^
    = note: the item is gated behind the `winuser` feature

Device:

  • OS: Windows 11

Active toolchain:

stable-x86_64-pc-windows-msvc (default)
rustc 1.76.0 (07dca489a 2024-02-04)
@Wumpf Wumpf added the bug Something isn't working label Feb 14, 2024
@Wumpf
Copy link
Author

Wumpf commented Feb 14, 2024

luckily cargo binstall still works

@emilk
Copy link
Collaborator

emilk commented Feb 14, 2024

Fix coming in egui 0.26.2: emilk/egui#4037

In the meantime try cargo install --locked puffin_viewer

@emilk
Copy link
Collaborator

emilk commented Feb 14, 2024

eframe 0.26.2 released - please verify cargo install puffin_viewer now works on Windows @Wumpf

@Wumpf
Copy link
Author

Wumpf commented Feb 14, 2024

Does not work. Puffin 0.19 is on eframe 0.25:

 Compiling puffin_egui v0.25.0
 Compiling eframe v0.25.0

@Wumpf
Copy link
Author

Wumpf commented Feb 14, 2024

oh and as suspected, --locked works

emilk added a commit that referenced this issue Jul 31, 2024
@emilk
Copy link
Collaborator

emilk commented Jul 31, 2024

This should be fixed now. New puffin release coming shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants