Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigParams and PixelStreamingOverrides classes are not explicitly exported at the top level #367

Closed
DenisTensorWorks opened this issue Dec 17, 2024 · 1 comment · Fixed by #368
Labels
bug Something isn't working never-stale

Comments

@DenisTensorWorks
Copy link
Collaborator

UE Version:
E.g. UE 5.5

Frontend Version:
E.g. UE5.5

Problem component
Frtonetn libraries

Description
ConfigParams and PixelStreamingOverrides classes are not properly exported at the top level, so any users needing to import them, have to implement hacky solution, such as importing them from dist.

Expected behavior
Users should be able to be import these classes from the top-level library.

@DenisTensorWorks DenisTensorWorks added bug Something isn't working never-stale labels Dec 17, 2024
@lukehb
Copy link
Contributor

lukehb commented Dec 17, 2024

Currently downstream users are doing things like this:

import { PixelStreamingOverrides } from "@epicgames-ps/lib-pixelstreamingfrontend-ue5.5/dist/types/PixelStreaming/PixelStreaming";
import { ConfigParams } from "@epicgames-ps/lib-pixelstreamingfrontend-ue5.5/dist/types/Config/Config";

This should not be needed.

It should simply be:

import { PixelStreamingOverrides, ConfigParams  } from "@epicgames-ps/lib-pixelstreamingfrontend-ue5.5";

This is caused by not exporting these types in the src\pixelstreamingfrontend.ts file. In both cases here, I think this could be resolved by using * syntax on the export, such as:

export * from './Config/Config'

@lukehb lukehb linked a pull request Dec 17, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working never-stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants