Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up frontend library exports #368

Merged

Conversation

mcottontensor
Copy link
Collaborator

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Some useful classes are not exported leading to hacky solutions.

Solution

Properly added a bunch of new exports in the library. Also cleaned up some existing exports.

@mcottontensor mcottontensor added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.5 labels Dec 17, 2024
@mcottontensor mcottontensor merged commit 1bebedd into EpicGamesExt:master Dec 17, 2024
7 checks passed
@mcottontensor mcottontensor deleted the more-frontend-exports branch December 17, 2024 04:35
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
UE5.4 Backport failed because of merge conflicts
UE5.3 Backport failed because of merge conflicts
UE5.5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 368

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mcottontensor added a commit that referenced this pull request Dec 17, 2024
[UE5.5] Merge pull request #368 from mcottontensor/more-frontend-exports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigParams and PixelStreamingOverrides classes are not explicitly exported at the top level
2 participants