-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fullscreen button on iPad if using a non Safari browser #334
Conversation
@@ -21,7 +21,7 @@ | |||
</head> | |||
|
|||
<!-- The Pixel Streaming player fills 100% of its parent element but body has a 0px height unless filled with content. As such, we explicitly force the body to be 100% of the viewport height --> | |||
<body style="width: 100vw; height: 100svh; min-height: -webkit-fill-available; font-family: 'Montserrat'; margin: 0px"> | |||
<body style="width: 100vw; height: 100svh; min-height: -webkit-fill-available; overflow: hidden; overscroll-behavior: none; font-family: 'Montserrat'; margin: 0px"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes scroll bounce zone on iPad that is unhelpful for Pixel Streaming
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Remove fullscreen button on iPad if using a non Safari browser (cherry picked from commit 3f10f01) # Conflicts: # Frontend/implementations/EpicGames/src/player.html # Frontend/ui-library/src/Application/Application.ts
Remove fullscreen button on iPad if using a non Safari browser (cherry picked from commit 3f10f01) # Conflicts: # Frontend/ui-library/src/Application/Application.ts
Remove fullscreen button on iPad if using a non Safari browser (cherry picked from commit 3f10f01) # Conflicts: # Frontend/ui-library/src/Application/Application.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
[UE5.2] Merge pull request #334 from EpicGamesExt/issue219
[UE5.3] Merge pull request #334 from EpicGamesExt/issue219
[UE5.4] Merge pull request #334 from EpicGamesExt/issue219
Relevant components:
Problem statement:
#219
Using fullscreen video on iPad + touch interactions + non-Safari browsers = video gets dragged around the screen.
This is fairly unusable for Pixel Streaming but it browser defined behaviour that can't be disabled it seems.
Additionally if you leave fullscreen from one of these non-Safari browsers on the iPad the video stream will pause and cannot be resumed without re-entering fullscreen mode because we hide the video controls.
Solution
Don't allow fullscreen button on these non-Safari browsers on iPad.
Documentation
N/A
Test Plan and Compatibility
Test on iPad on Safari = button still shows up
Test on iPad on Chrome = button is gone