Merging 5.5 into master

.github/workflows/create-gh-release.yml

@@ -69,6 +69,7 @@ jobs:
           .git
           .github
           output
+          node_modules
           Common/build
           Common/docs
           Common/node_modules
@@ -102,20 +103,27 @@ jobs:
           */.git/*
           */.github/*
           */node_modules/*
+          /*/node_modules/*
           */output/*
           /*/Common/build/*
           /*/Common/docs/*
+          /*/Common/node_modules/*
           /*/Docs/*
           /*/Extras/*
           /*/Frontend/Docs/*
+          /*/Frontend/node_modules/*
           /*/Frontend/library/dist/*
           /*/Frontend/library/types/*
           /*/Frontend/ui-library/dist/*
           /*/Frontend/ui-library/types/*
+          /*/Frontend/ui-library/node_modules/*
+          /*/Frontend/implementations/typescript/node_modules
           /*/SFU/Docs/*
           /*/Signalling/build/*
           /*/Signalling/docs/*
+          /*/Signalling/node_modules/*
           /*/SignallingWebServer/build/*
+          /*/SignallingWebServer/node_modules/*
           /*/SS_Test/*
 
     - name: "Make the release"

.github/workflows/healthcheck-libraries.yml

@@ -57,100 +57,4 @@ jobs:
 
     - name: Clean build of frontend implementation
       working-directory: Frontend/implementations/typescript
-      run: npm install && npm run build
-
-  build-signalling-only:
-    if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout source code
-      uses: actions/checkout@v3
-      with:
-          sparse-checkout: 'Signalling'
-          sparse-checkout-cone-mode: false
-
-    - uses: actions/setup-node@v4
-      with:
-        node-version: "${{ env.NODE_VERSION }}"
-        registry-url: 'https://registry.npmjs.org'
-
-    - name: Build signalling using published packages only
-      working-directory: Signalling
-      run: npm install && npm run build && npm run lint
-
-  build-wilbur-only:
-    if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout source code
-      uses: actions/checkout@v3
-      with:
-          sparse-checkout: 'SignallingWebServer'
-          sparse-checkout-cone-mode: false
-
-    - uses: actions/setup-node@v4
-      with:
-        node-version: "${{ env.NODE_VERSION }}"
-        registry-url: 'https://registry.npmjs.org'
-
-    - name: Build Wilbur using published packages only
-      working-directory: SignallingWebServer
-      run: npm install && npm run build && npm run lint
-
-  build-frontend-only:
-    if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout source code
-      uses: actions/checkout@v3
-      with:
-          sparse-checkout: 'Frontend/library'
-          sparse-checkout-cone-mode: false
-
-    - uses: actions/setup-node@v4
-      with:
-        node-version: "${{ env.NODE_VERSION }}"
-        registry-url: 'https://registry.npmjs.org'
-
-    - name: Build Frontend/library using published packages only
-      working-directory: Frontend/library
-      run: npm install && npm run build && npm run lint && npm run test
-
-  build-frontend-ui-only:
-    if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout source code
-      uses: actions/checkout@v3
-      with:
-          sparse-checkout: 'Frontend/ui-library'
-          sparse-checkout-cone-mode: false
-
-    - uses: actions/setup-node@v4
-      with:
-        node-version: "${{ env.NODE_VERSION }}"
-        registry-url: 'https://registry.npmjs.org'
-
-    - name: Build Frontend/ui-library using published packages only
-      working-directory: Frontend/ui-library
-      run: npm install && npm run build && npm run lint
-
-  build-implementation-typescript-only:
-    if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout source code
-      uses: actions/checkout@v3
-      with:
-          sparse-checkout: 'Frontend/implementations/typescript'
-          sparse-checkout-cone-mode: false
-
-    - uses: actions/setup-node@v4
-      with:
-        node-version: "${{ env.NODE_VERSION }}"
-        registry-url: 'https://registry.npmjs.org'
-
-    - name: Build Frontend/implementations/typescript using published packages only
-      working-directory: Frontend/implementations/typescript
-      run: npm install && npm run build
-
+      run: npm install && npm run build

.github/workflows/healthcheck-libs-with-public-deps.yml

@@ -0,0 +1,105 @@
+name: Check health of libraries (public deps)
+
+on:
+  workflow_dispatch:
+  push:
+    paths:
+      - "Common/**"
+      - "Signalling/**"
+      - "SignallingWebServer/**"
+      - "Frontend/library/**"
+      - "Frontend/ui-library/**"
+      - "Frontend/implementations/typescript/**"
+  pull_request:
+    paths:
+      - "Common/**"
+      - "Signalling/**"
+      - "SignallingWebServer/**"
+      - "Frontend/library/**"
+      - "Frontend/ui-library/**"
+      - "Frontend/implementations/typescript/**"
+
+env:
+  NODE_VERSION: 18.17.x
+
+jobs:
+  check-if-bypass:
+      runs-on: ubuntu-latest
+      outputs:
+        bypass: ${{ steps.checkbypass.outputs.bypass }}
+      steps:
+      - name: Checkout source code
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 5  # This should be enough history to contain the commit that triggered the PR
+
+      - name: Check commit message for push event
+        if: github.event_name == 'push'
+        run: |
+          COMMIT="${{ github.event.head_commit.message }}"
+          echo "Commit message: $COMMIT"
+          echo "COMMIT=$COMMIT" >> $GITHUB_ENV
+
+      - name: Check commit message for pull request event
+        if: github.event_name == 'pull_request'
+        run: |
+          # Get the latest commit SHA for the pull request
+          COMMIT_SHA="${{ github.event.pull_request.head.sha }}"
+          echo "Fetching commit message for PR commit: $COMMIT_SHA"
+          COMMIT_MESSAGE=$(git log -1 --pretty=%B "$COMMIT_SHA")
+          echo "Commit message: $COMMIT_MESSAGE"
+          echo "COMMIT=$COMMIT_MESSAGE" >> $GITHUB_ENV
+
+      - name: Check commit message for bypass
+        id: checkbypass
+        run: |
+          echo "$COMMIT"
+          if echo "$COMMIT" | grep -q "#bypass-publish-check"; then
+            echo "bypass=true" >> $GITHUB_OUTPUT
+            echo "bypass=true"
+          else
+            echo "bypass=false" >> $GITHUB_OUTPUT
+            echo "bypass=false"
+          fi
+
+  build-using-public-deps:
+      needs: check-if-bypass
+      if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure' && needs.check-if-bypass.outputs.bypass == 'false' # Only run if bypass is false
+      runs-on: ubuntu-latest
+      steps:
+
+      - name: Checkout source code
+        uses: actions/checkout@v3
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: "${{ env.NODE_VERSION }}"
+          registry-url: 'https://registry.npmjs.org'
+
+      - name: Remove NPM workspaces
+        run: rm package.json && rm package-lock.json
+
+      - name: Build signalling using published packages only
+        if: always()
+        working-directory: Signalling
+        run: npm install && npm run build && npm run lint
+
+      - name: Build Wilbur using published packages only
+        if: always()
+        working-directory: SignallingWebServer
+        run: npm install && npm run build && npm run lint
+
+      - name: Build Frontend/library using published packages only
+        if: always()
+        working-directory: Frontend/library
+        run: npm install && npm run build && npm run lint && npm run test
+
+      - name: Build Frontend/ui-library using published packages only
+        if: always()
+        working-directory: Frontend/ui-library
+        run: npm install && npm run build && npm run lint
+
+      - name: Build Frontend/implementations/typescript using published packages only
+        if: always()
+        working-directory: Frontend/implementations/typescript
+        run: npm install && npm run build

.github/workflows/healthcheck-streaming.yml

@@ -18,31 +18,32 @@ on:
       - "Extras/**"
 
 jobs:
-  streaming-test-linux:
-    if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout source code
-      uses: actions/checkout@v3
+  # Uncomment when we can Linux test to capture a non-black screenshot using software renderer.
+  # streaming-test-linux:
+  #   if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #   - name: Checkout source code
+  #     uses: actions/checkout@v3
 
-    - name: Create results directory
-      run: mkdir Extras/MinimalStreamTester/results
-
-    - name: Launch stream test in docker containers
-      uses: isbang/compose-action@v1.5.1
-      with:
-        compose-file: "Extras/MinimalStreamTester/docker-compose.yml"
-        up-flags: "--build --abort-on-container-exit --exit-code-from tester"
-
-    - name: Get short sha
-      id: vars
-      run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
+  #   - name: Create results directory
+  #     run: mkdir Extras/MinimalStreamTester/results
+
+  #   - name: Launch stream test in docker containers
+  #     uses: isbang/compose-action@v1.5.1
+  #     with:
+  #       compose-file: "Extras/MinimalStreamTester/docker-compose.yml"
+  #       up-flags: "--build --abort-on-container-exit --exit-code-from tester"
+
+  #   - name: Get short sha
+  #     id: vars
+  #     run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
 
-    - name: Upload results
-      uses: actions/upload-artifact@v4
-      with:
-        name: Results-${{ steps.vars.outputs.sha_short }}-Linux
-        path: Extras/MinimalStreamTester/results
+  #   - name: Upload results
+  #     uses: actions/upload-artifact@v4
+  #     with:
+  #       name: Results-${{ steps.vars.outputs.sha_short }}-Linux
+  #       path: Extras/MinimalStreamTester/results
 
   streaming-test-win:
     if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'