Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use afterPropertiesSet to initialize authenticationSource #266

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

mljohns89
Copy link
Contributor

Have you read the docs first?

OK, describe you changes:
@albogdano 1000 apologies.

When you call contextSource.afterPropertiesSet(), it will not have any affect unless the contextSource.authenticationSource is null. I've removed the line that initializes the authenticationSource to the empty SpringSecurityAuthenticationSource()

Tests?
Tested this via debugging and set the authenticationSource to null manually. LDAP Login worked correctly

@albogdano
Copy link
Member

Right, so apparently setting authenticationSource to SpringSecurityAuthenticationSource is not really needed, since there won't be any credentials initially stored in the security context.

@albogdano albogdano merged commit c6a66e3 into Erudika:master Apr 8, 2024
1 check passed
@albogdano
Copy link
Member

Thanks again, Michael! Please update Para to 1.49.5, which was just published.

@mljohns89
Copy link
Contributor Author

mljohns89 commented Apr 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants