Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v.next warnings #1561

Merged
merged 15 commits into from
Mar 4, 2025
Merged

Fix v.next warnings #1561

merged 15 commits into from
Mar 4, 2025

Conversation

williambohrmann3
Copy link
Collaborator

Description

Addresses warnings introduced by .NET 9 upgrade and Maps SDK 200.7.

Type of change

  • Sample viewer enhancement

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@williambohrmann3
remove dotnet/core/issues/7176 workaround
144ec47 
issue has already been resolved, resolves NU1505 warning
@williambohrmann3
remove use of Application.Current.MainPage
58d58a5 
addresses CS0618
@williambohrmann3
override CreateWindow()
73196ea
@williambohrmann3
use Application.Current.Windows[0].Page
147e37d 
for non-ContentPages
@williambohrmann3
replace Frame with Border
7abdd58
@williambohrmann3
SimulatedDataSource MAUI - warnings
b4cc8b3
@williambohrmann3
remove _lastViewedFileIndex
1ca17c2 
this is always 0; this ensures C# code displays first
@williambohrmann3
image buffering: read exact
19f3a51
@williambohrmann3
busy indicator
872f651 
resolves: 'ValidateUtilityNetworkTopology.IsBusy' hides inherited member 'Page.IsBusy'. Use the new keyword if hiding was intended.
@williambohrmann3
use AppContext.BaseDirectory
9a543e2 
per warning suggestion
@williambohrmann3
android api 31 condition for bluetooth scan perm
5554e05
@williambohrmann3
correct mac supported os version
4b090bf
@williambohrmann3
disable CA1422
966d5d4 
deprecated APIs; will resolve in another PR
@williambohrmann3
replcae use of deprecated KeyWindow API
42d88e3
@williambohrmann3 williambohrmann3 self-assigned this Mar 3, 2025
dotMorten
dotMorten approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@dotMorten dotMorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a minor comment on use of pragma

@williambohrmann3 williambohrmann3 merged commit 8596a05 into v.next Mar 4, 2025
2 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/vnext-warnings branch March 4, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotMorten dotMorten dotMorten approved these changes

@duffh duffh Awaiting requested review from duffh

Assignees

@williambohrmann3 williambohrmann3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williambohrmann3 @dotMorten @duffh