chore: rename READMEs for consistency #11703
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
calcite-admin
added
the
skip visual snapshots
jcfranco
changed the title
benelan
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Nice the lowercase always bothered me lol. It was a Stencil thing right? IIRC the component readmes were generated in lowercase.
I think there are references to readme.md in the CI and possibly support scripts. Can you make sure to change those to README.md too? Also the "extra-files" in the release-please config.
benelan
approved these changes
Mar 6, 2025
|
Yeah the second commit came in after I started reviewing, you got all of the references. Can you uppercase the monorepo root |
|
@benelan Fixed! Thanks for the catch. 🎣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
✨🧹✨