Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editsign does not always edit the targeted sign #3756

Closed
SiuanSong opened this issue Nov 3, 2020 · 0 comments · Fixed by #3763
Closed

Editsign does not always edit the targeted sign #3756

SiuanSong opened this issue Nov 3, 2020 · 0 comments · Fixed by #3763
Labels
bug: unconfirmed Potential bugs that need replicating to verify.
Milestone
2.18.2

Comments

@SiuanSong
Copy link

Information

Full output of /ess version:

[03-Nov-2020 16:47:53] Server version: 1.16.3-R0.1-SNAPSHOT git-Paper-246 (MC: 1.16.3)
[03-Nov-2020 16:47:53] EssentialsX version: 2.18.1.32
[03-Nov-2020 16:47:53] PlaceholderAPI version: 2.10.9
[03-Nov-2020 16:47:53] PermissionsEx version: 1.23.4
[03-Nov-2020 16:47:53] Vault version: 1.7.3-b131
[03-Nov-2020 16:47:53] EssentialsXGeoIP version: 2.18.1.32
[03-Nov-2020 16:47:53] EssentialsXSpawn version: 2.18.1.32
[03-Nov-2020 16:47:53] You are running unsupported plugins!
[03-Nov-2020 16:47:53] You are running an unsupported server version!

Server startup log:

https://gist.github.com/SiuanSong/a03e31e6ae580f7fa689d7dccfafd873

EssentialsX config:

https://gist.github.com/SiuanSong/0860f14d3f26de528f5654d861755152

Details

Description:

Editsign does not always edit the sign you are trying to target. It seems to target the sign at your characters eye level instead of the sign targeted by your mouse.
Steps to reproduce:

Stand in front of a wall of signs and try to edit one thats not directly in your eye level view by placing your cursor over it.
Expected behavior:

I expect the sign that was targeted with my cursor to be changed.
Console stack trace:

Screenshots:

https://drive.google.com/file/d/1WOKlI9sJ8hkiRboIarwQpU93Yp7yW52V/view?usp=sharing
@SiuanSong SiuanSong added the bug: unconfirmed Potential bugs that need replicating to verify. label Nov 3, 2020
@JRoy JRoy mentioned this issue Nov 9, 2020
Merged
@JRoy JRoy added this to the 2.18.2 milestone Nov 9, 2020
mdcfe pushed a commit that referenced this issue Nov 9, 2020
@JRoy
Use ray-tracing based target block for 1.13.2+ (#3763)
5b0c2a4 
Uses new method of ray-tracing to target block instead of using BlockIterator which doesn't respect the player looking at a different y-level. Falls back to old BlockIterator method on server versions older than 1.13.2

Fixes #3756.
Chew pushed a commit to Chew/Essentials that referenced this issue Nov 25, 2020
@JRoy @Chew
Use ray-tracing based target block for 1.13.2+ (EssentialsX#3763)
6029380 
Uses new method of ray-tracing to target block instead of using BlockIterator which doesn't respect the player looking at a different y-level. Falls back to old BlockIterator method on server versions older than 1.13.2

Fixes EssentialsX#3756.
DarkEyeDragon pushed a commit to DarkEyeDragon/Essentials that referenced this issue Dec 24, 2020
@JRoy @DarkEyeDragon
Use ray-tracing based target block for 1.13.2+ (EssentialsX#3763)
ca0a671 
Uses new method of ray-tracing to target block instead of using BlockIterator which doesn't respect the player looking at a different y-level. Falls back to old BlockIterator method on server versions older than 1.13.2

Fixes EssentialsX#3756.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: unconfirmed Potential bugs that need replicating to verify.
Projects
None yet
Milestone
2.18.2
Development

Successfully merging a pull request may close this issue.

Use ray-tracing based target block for 1.13.2+ JRoy/Essentials-PR
2 participants
@JRoy @SiuanSong