Ensure LOGGER is not equal to plugin logger before setting parent #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaperMC/Paper#890 introduced minor changes to the plugin logger to make plugin prefixes independent from the logging framework. As a result, the plugin logger now uses the plugin name as name. Essentials uses the same logger name and redirects messages to the plugin logger by setting it as a parent. However, in newer Paper builds both loggers are now equal, resulting in infinite loops when logging messages because the logger has itself as parent. Make sure the two loggers are not equal before setting the parent to avoid the following warning on newer Paper builds: [Essentials] Ignoring attempt to change parent of plugin logger
mdcfe
approved these changes
Sep 29, 2017
|
Thank you. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaperMC/Paper#890 introduced minor changes to the plugin logger to make plugin prefixes independent from the logging framework. As a result, the plugin logger now uses the plugin name as name.
Essentials uses the same logger name and redirects messages to the plugin logger by setting it as a parent. However, in newer Paper builds both loggers are now equal, resulting in infinite loops when logging messages because the logger has itself as parent.
Make sure the two loggers are not equal before setting the parent to avoid the following warning on newer Paper builds:
(On Spigot and older Paper builds this will not be true so the parent is still set correctly.)