Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vault prefix/suffix support to EssXChat #1663

Merged
merged 2 commits into from
Jan 21, 2018
Merged

Add Vault prefix/suffix support to EssXChat #1663

merged 2 commits into from
Jan 21, 2018

Conversation

mdcfe
Copy link
Member

@mdcfe mdcfe commented Nov 23, 2017

Add support for replacing Vault prefixes and suffixes in chat to EssentialsX Chat, using the variables {VAULTPREFIX} and {VAULTSUFFIX}.

Includes an example of how to use it in the config.

@mdcfe mdcfe mentioned this pull request Nov 23, 2017
Closed
@mdcfe
Copy link
Member Author

mdcfe commented Dec 27, 2017

@drtshock @SupaHam Thoughts on removing VAULT from the variables, since Vault isn't technically the only supported permissions handler?

@mdcfe mdcfe requested a review from drtshock December 27, 2017 13:46
@mdcfe
Copy link
Member Author

mdcfe commented Dec 27, 2017 •
edited
Loading

Also, I feel that the double replacements in the chat format ({<named placeholder>} to {<number>} in Settings before actual formatting in EssChat) might be a bit redundant - is it worth keeping?

@mdcfe mdcfe added the type: enhancement Features and feature requests. label Dec 27, 2017
@lucko
Copy link
Contributor

lucko commented Dec 27, 2017

{PREFIX} and {SUFFIX} are more suitable names imo.

@mdcfe mdcfe force-pushed the add-vault-chat-format branch from 6b4f568 to 6c0a9b7 Compare January 11, 2018 18:42
@mdcfe mdcfe requested review from SupaHam and drtshock and removed request for drtshock January 11, 2018 18:43
@drtshock drtshock merged commit 738efe8 into EssentialsX:2.x Jan 21, 2018
@mdcfe mdcfe mentioned this pull request Jan 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drtshock drtshock drtshock approved these changes

@SupaHam SupaHam Awaiting requested review from SupaHam

Assignees
No one assigned
Labels
type: enhancement Features and feature requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdcfe @lucko @drtshock