Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow setting bed homes in non-overworld dimensions #2335

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Disallow setting bed homes in non-overworld dimensions #2335

merged 1 commit into from
Jan 5, 2019

Conversation

triagonal
Copy link
Member

Closes #2313.

Beds will explode upon right-click in Nether and End dimensions, rendering the newly set bed home useless. Instead of that happening, bed homes will only be set in the overworld.

mdcfe
mdcfe reviewed Jan 1, 2019
View reviewed changes
Copy link
Member

@mdcfe mdcfe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fell this would be behind a config option, but at the same time I'm not sure what utility there would be for disabling this. It's probably fine as-is.

DoNotSpamPls
DoNotSpamPls approved these changes Jan 1, 2019
View reviewed changes
Copy link
Member

@DoNotSpamPls DoNotSpamPls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, there is zero need to have a bed home set where a bed doesn't exist.

@mdcfe mdcfe added this to the 2.16.1: Let There Be Bugfixes milestone Jan 1, 2019
@mdcfe mdcfe merged commit 7948e76 into EssentialsX:2.x Jan 5, 2019
@triagonal triagonal deleted the issue-2313 branch January 6, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdcfe mdcfe mdcfe approved these changes

@DoNotSpamPls DoNotSpamPls DoNotSpamPls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.16.1: The Below-1.13 Update
Development

Successfully merging this pull request may close these issues.
3 participants
@triagonal @mdcfe @DoNotSpamPls