Update to 1.15 #2873
Merged
Update to 1.15 #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d0ab84e
This needs more work as this currently breaks > 1.15 support
|
Testing is done, ready for review! |
pop4959
approved these changes
Dec 11, 2019
|
Looks good to me. Waiting for md since he will probably still need to update ItemDB using those scripts you were mentioning. Methods missing in OfflinePlayer doesn't matter, as it's only relevant for compilation. Since they are never actually called anywhere, it should never throw a MethodNotFoundException while running on a server using an older API version. |
mdcfe
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates Essentials to target 1.15. Additionally, if you're already reviewing this, may you review #2824 as well as it's very minor
Changelog
WIP
Testingitems.jsonneeds to be generatedessx-scriptsfor this but it looked scary so I didn't commit it :o> 1.15 compatibility inOfflinePlayerdue to theAchievementclass being removed