Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditSign Command #3415

Merged
merged 6 commits into from
Jul 1, 2020
Merged

EditSign Command #3415

merged 6 commits into from
Jul 1, 2020

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Jun 26, 2020

bro so epic bro

@JRoy JRoy added the type: enhancement Features and feature requests. label Jun 26, 2020
@JRoy JRoy added this to the 2.18.0 milestone Jun 26, 2020
@JRoy JRoy requested review from mdcfe, pop4959 and darbyjack June 26, 2020 16:15
@JRoy JRoy requested a review from mdcfe June 27, 2020 03:29
Copy link
Member

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes necessary, command looks neat though

@JRoy JRoy requested a review from pop4959 June 27, 2020 03:59
pop4959
pop4959 previously approved these changes Jun 27, 2020
Co-authored-by: MD <1917406+md678685@users.noreply.github.com>
@mdcfe mdcfe merged commit 7a5aea0 into EssentialsX:2.x Jul 1, 2020
@mdcfe mdcfe deleted the feature/sign-command branch July 1, 2020 20:58
JRoy added a commit to JRoy/Essentials-PR that referenced this pull request Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants