Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creeper player damage being cancelled incorrectly #3604

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

xtomyserrax
Copy link
Contributor

Fixes issue #3603

Basicly there was a mistake which also asked for creeper-explosion to be disabled, and all other checkers just ask for playerdm

@pop4959 pop4959 added the bug: confirmed Confirmed bugs in EssentialsX. label Aug 17, 2020
@mdcfe mdcfe changed the title Fixes issue with creeper explosion and playerdamage Fix creeper player damage being cancelled incorrectly Aug 22, 2020
@mdcfe mdcfe merged commit 5fa65b4 into EssentialsX:2.x Aug 22, 2020
@mdcfe mdcfe added this to the 2.18.1 milestone Aug 22, 2020
@mdcfe
Copy link
Member

mdcfe commented Aug 22, 2020

Added message to commit for clarity:

Previously, disabling creeper explosion block damage with the protect.prevent.creeper-explosion setting would also prevent players getting hurt. This fixes this, meaning servers can disable creeper block damage while still allowing players to take damage from creeper explosions.

JRoy pushed a commit to JRoy/Essentials-PR that referenced this pull request Aug 30, 2020
Previously, disabling creeper explosion block damage with the `protect.prevent.creeper-explosion` setting would also prevent players getting hurt. This fixes this, meaning servers can disable creeper block damage while still allowing players to take damage from creeper explosions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed Confirmed bugs in EssentialsX.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants