Migrate to Configurate #4072
Merged
Migrate to Configurate #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
previously requested changes
Jun 6, 2021
Essentials/src/main/java/com/earth2me/essentials/api/IJails.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Riley Park <riley.park@meino.net>
zml2008
suggested changes
Jun 6, 2021
Essentials/src/main/java/com/earth2me/essentials/commands/Commandcreatekit.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/commands/Commandcreatekit.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/config/EssentialsConfiguration.java
Outdated
Show resolved
Hide resolved
|
|
||
| try { | ||
| final UUID worldId = UUID.fromString(worldValue); | ||
| world = Bukkit.getWorld(worldId); |
There was a problem hiding this comment.
this is bad --- what if a location is stored for an unloaded world?
probably a pain to fix and I've seen this in iirc Jails as well, so can be handled in a later pass
Co-authored-by: zml <zml@aoeu.xyz>
zml2008
previously approved these changes
Jun 6, 2021
pop4959
previously approved these changes
Jun 6, 2021
mdcfe
previously requested changes
Jun 7, 2021
# Conflicts: # build.gradle
|
Thanks to all the reviewers for helping us get this merged and to @zml2008 for being epic |
mdcfe
pushed a commit
that referenced
this pull request
Jun 9, 2021
Fix regression from #4072, tested in #essx-support on MOSS
This was referenced Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates all uses of SnakeYAML and Bukkit's Configuration API to Sponge's Configurate.
Configurate enables us to the do the following stuff;