Support 0>y>256 for safe/random teleports #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pop4959
reviewed
Nov 23, 2021
Essentials/src/main/java/com/earth2me/essentials/RandomTeleport.java
Outdated
Show resolved
Hide resolved
...rs/BaseProviders/src/main/java/net/ess3/provider/providers/FixedHeightWorldInfoProvider.java
Outdated
Show resolved
Hide resolved
Co-authored-by: pop4959 <pop4959@gmail.com>
JRoy
approved these changes
Nov 24, 2021
JRoy
changed the title
JRoy
added a commit
that referenced
this pull request
Nov 24, 2021
Co-authored-by: pop4959 <pop4959@gmail.com> Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
JRoy
added a commit
that referenced
this pull request
Nov 25, 2021
Co-authored-by: pop4959 <pop4959@gmail.com> Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
JRoy
added a commit
that referenced
this pull request
Nov 26, 2021
Co-authored-by: pop4959 <pop4959@gmail.com> Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
JRoy
added a commit
that referenced
this pull request
Nov 26, 2021
Co-authored-by: pop4959 <pop4959@gmail.com> Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
mdcfe
added a commit
that referenced
this pull request
Nov 30, 2021
Co-authored-by: pop4959 <pop4959@gmail.com> Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
WorldInfoProviderwhich exposes the correct minimum and maximum logical heights for worlds, and updates the safe location methods to use this provider. This should also mitigate safe teleport nether roof exploits.