Add UUID support to trade and protection signs #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
added
type: enhancement
JRoy
force-pushed
the
feature/sign-uuids
branch
from
138eb6e to
cb1a3eb
Compare
|
Do we still need protection signs? They've been deprecated / basically unused for years afaik. |
I had no idea that this was an Essentials feature until this pull request but either way probably not the place to remove it. |
pop4959
approved these changes
Feb 13, 2022
mdcfe
reviewed
Mar 8, 2022
| final Sign sign = (Sign) signProvider.getBlock().getState(); | ||
| if (ess.getSignDataProvider() == null || ess.getSignDataProvider().getSignData(sign, "owner") == null) { | ||
| if (ess.getSignDataProvider() != null) { | ||
| ess.getSignDataProvider().setSignData(sign, "owner", user.getUUID().toString()); |
There was a problem hiding this comment.
This check changes the owner to the user without verifying who the user is first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UUID support for 1.14+, without asm there is no way to backport this. Defaults to username based system for legacy versions.