Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and remove unnecessary hex encode/decode #185

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

alisinabh
Copy link
Member

  • Updated Ethers module to use Transaction.to_rpc_map for tx_params.
  • Simplified pre_process function in Ethers module by concatenating contract_binary and encoded_constructor directly.
  • Removed unnecessary hex_encode calls in Ethers.Contract module.
  • Decoded contract binary in maybe_read_contract_binary function in Ethers.ContractHelpers.
  • Removed hex_decode! import and calls in Ethers.Multicall module.
  • Simplified new function in Ethers.Transaction module by removing redundant input handling.
  • Updated to_rpc_map function in Ethers.Transaction module to encode data and input fields.
  • Removed hex_decode! call in inspect function in Ethers.TxData module.
  • Updated tests to use Utils.hex_decode! where necessary.

@alisinabh alisinabh self-assigned this Jan 23, 2025
@alisinabh alisinabh merged commit 7f41d11 into main Jan 23, 2025
4 checks passed
@alisinabh alisinabh deleted the use-binary-as-default branch January 23, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant