Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Use public/private for target_link_libraries in add_flamegpu_executable #701

Closed
ptheywood opened this issue Oct 4, 2021 · 0 comments · Fixed by #703
Closed

CMake: Use public/private for target_link_libraries in add_flamegpu_executable #701

ptheywood opened this issue Oct 4, 2021 · 0 comments · Fixed by #703
Labels
cmake

Comments

@ptheywood
Copy link
Member

CMake was previously refactored to use PUBLIC/PRIVATE/Intergace for link/includes for the main library, but I missed 2 calls for executable creation which still use the generic target_link_libraries. This should instead use PRIVATE so users can do the same.

FLAMEGPU2/cmake/common.cmake

Line 311 in 76c7d2d

target_link_libraries(${NAME} flamegpu)

FLAMEGPU2/cmake/common.cmake

Line 316 in 76c7d2d

target_link_libraries(${NAME} "${CMAKE_CURRENT_BINARY_DIR}/$<TARGET_FILE:flamegpu>")

@ptheywood ptheywood added the cmake label Oct 4, 2021
@ptheywood ptheywood changed the title CMakeL Use Public/private for target_link_libraries in add_flamegpu_executable CMake: Use public/private for target_link_libraries in add_flamegpu_executable Oct 4, 2021
ptheywood added a commit that referenced this issue Oct 6, 2021
@ptheywood
CMake: Ensure all target_link_libraries specify public/private/interface
aefdf99 
Closes #701
@ptheywood ptheywood mentioned this issue Oct 6, 2021
Merged
mondus pushed a commit that referenced this issue Oct 6, 2021
@ptheywood @mondus
CMake: Ensure all target_link_libraries specify public/private/interface
609e1bc 
Closes #701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMake: Ensure all target_link_libraries specify public/private/interface FLAMEGPU/FLAMEGPU2
1 participant
@ptheywood