Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use std::default_random_engine #754

Closed
ptheywood opened this issue Dec 14, 2021 · 0 comments · Fixed by #863
Closed

Do not use std::default_random_engine #754

ptheywood opened this issue Dec 14, 2021 · 0 comments · Fixed by #863

Comments

@ptheywood
Copy link
Member

std::default_random_engine is implementation defined, so different sequences are used on different platforms which is not ideal.

Most occurences were updated to use std::mt19937_64, the 64 bit mersenne twister implementation in the standard library, but there are currenlty 39 occurances in the test suite of the default being used (likely in PR's or based on tests from before the change to 64 bit mt was made).

These should be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant