Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: RunPlanVector::setPropertyUniformDistribution() #823

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Mar 25, 2022

would round non-integer values.

Have improved the existing test to now check exact values (previously it just checked ordering). Similarly added a floating point cases in a range whereby lerp will produce non integer values.

@Robadob Robadob added the bug label Mar 25, 2022
@Robadob Robadob requested a review from ptheywood March 25, 2022 13:35
@Robadob Robadob self-assigned this Mar 25, 2022
@Robadob Robadob force-pushed the bugfix_RunPlanVec_uniformdist_real branch from 3a830a8 to 63b1cff Compare March 25, 2022 13:53
…on-integer values.

Additionally improved the existing test to check for exact values
@Robadob Robadob force-pushed the bugfix_RunPlanVec_uniformdist_real branch from 63b1cff to 34bf393 Compare March 25, 2022 14:36
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Tests pass under linux

./bin/Release/tests --gtest_filter="TestRunPlanVector.*"
... 
[  PASSED  ] 15 tests.

@Robadob Robadob merged commit d8714a2 into master Mar 25, 2022
@Robadob Robadob deleted the bugfix_RunPlanVec_uniformdist_real branch March 25, 2022 15:18
@ptheywood ptheywood added this to the v2.0.0-alpha.3 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants