Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.7. support for code generator #917

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Python 3.7. support for code generator #917

merged 2 commits into from
Sep 1, 2022

Conversation

mondus
Copy link
Member

@mondus mondus commented Sep 1, 2022

Fixes Bug #915

Mostly a case of Python 3.7 using ast feature depreciated in Python 3.8+. Special cases have been used to detect these for Python 3.7.

@mondus mondus self-assigned this Sep 1, 2022
ptheywood
ptheywood approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codegen tests now all pass under linux for pythons 3.7, 3.8 and 3.9.
The full test suite passed for 3.7, and assumed to work for more recent versions.

Needs squashing / rebase fixuping.

@mondus mondus merged commit a2bd39f into master Sep 1, 2022
@mondus mondus deleted the python37bug branch September 1, 2022 16:27
@ptheywood ptheywood mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptheywood ptheywood ptheywood approved these changes

Assignees

@mondus mondus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondus @ptheywood