Handling NaN/Inf in JSON Output #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robadob
reviewed
Nov 11, 2022
Robadob
approved these changes
Nov 11, 2022
|
This should include a change to the docblocks / documentation statign that output JSON is RapdiJson's "relaxed" and can include nan etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #762
Uses RapidJSONs write and parse flags to relax the JSON standard and output
nanandinftype values. Not technically part of the JSON spec but this is the way in which RapidJSON deals with it. Alternative would be two writenanandinfas 0 but this would prevent fully serializing and loading a model.Requires changes to and test for;
NOTE: Testing json log outputs is very involved and requires writing a new JSON parser so it wont be done as part of this fix. Currently non out of logging tests test the actual file contents. A new issue (#970 ) for loading logs from JSON in log objects has been opened as a future feature than would then permit this to be tested.