feat(rclone): Implement support for empty salts #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an empty string is used as a salt then it should be replaced with a default one as also done by rclone: https://github.com/rclone/rclone/blob/b9bd15a8c980c36f15dd9b90bc0c422e4020baec/backend/crypt/cipher.go#L175 The default salt that must be used can be found here: https://github.com/rclone/rclone/blob/b9bd15a8c980c36f15dd9b90bc0c422e4020baec/backend/crypt/cipher.go#L54
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 93.58% 93.64% +0.05%
==========================================
Files 9 9
Lines 234 236 +2
==========================================
+ Hits 219 221 +2
Misses 15 15
Continue to review full report at Codecov.
|
|
@FWeinb any chance to have a look at this? cheers |
|
This look great, thanks for this PR. Would you mind adding a test for this behaviour? |
|
Added a test but wasn't sure in which file you wanted it. It should cover the empty salt case. Let me know if you find it sufficient. |
FWeinb
changed the title
|
Thanks. This looks great! |
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an empty string is used as a salt then it should be replaced with a default one as also done by rclone:
https://github.com/rclone/rclone/blob/b9bd15a8c980c36f15dd9b90bc0c422e4020baec/backend/crypt/cipher.go#L175
The default salt that must be used can be found here:
https://github.com/rclone/rclone/blob/b9bd15a8c980c36f15dd9b90bc0c422e4020baec/backend/crypt/cipher.go#L54