Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error for extra fields #14

Closed
rtimms opened this issue Dec 7, 2022 · 1 comment
Closed

Raise error for extra fields #14

rtimms opened this issue Dec 7, 2022 · 1 comment

Comments

@rtimms
Copy link
Collaborator

rtimms commented Dec 7, 2022

Raise an error if there are fields in the JSON file that aren't in the schema

See https://stackoverflow.com/questions/71837398/pydantic-validations-for-extra-fields-that-not-defined-in-schema
rtimms added a commit that referenced this issue Dec 12, 2022
@rtimms
#14 validate extra fields
a8295e1
rtimms added a commit that referenced this issue Dec 12, 2022
@rtimms
#14 update experiment test
7e8a9a7
rtimms added a commit that referenced this issue Dec 12, 2022
@rtimms
#14 typo
86006a0
martinjrobins added a commit that referenced this issue Dec 13, 2022
@martinjrobins
Merge pull request #16 from pybamm-team/issue-14-extra-fields
b0a5430 
#14 validate extra fields
@rtimms
Copy link
Collaborator Author

rtimms commented Dec 13, 2022

Fixed by #16

@rtimms rtimms closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rtimms