cpp-814 - bizops key should not be a prerequisite for running nori #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,6 +81,7 @@ function getRepositoryObject(data) { | |||
| } | |||
|
|
|||
| exports.handler = async ({ file }, state) => { | |||
| const { bizOps, bizOpsErrorHandler } = require('../lib/bizops') | |||
There was a problem hiding this comment.
suggestion: require is event-loop blocking, and if we wanted to migrate to ECMAScript Modules, this wouldn't work, so using await import(...) might be better:
Suggested change
| const { bizOps, bizOpsErrorHandler } = require('../lib/bizops') | |
| const { bizOps, bizOpsErrorHandler } = await import('../lib/bizops.js') |
There was a problem hiding this comment.
that's great, I'll do that, thanks Kara!
There was a problem hiding this comment.
On second thoughts - this is going to prove tricky - first we'd need to upgrade eslint and install babel-parser (fine) but second jest does not want to work with mixed cjs and esm, I paired with Serena for a while and eventually agreed it wasn't worth the investment involved. Any thoughts? @apaleslimghost
apaleslimghost
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users currently need to have a biz ops api key set to run nori. This is because it's exported as an instance on the
BizOpsClientclass, and is immediately instantiated when the commands that import it are initialised when the program loads.This pr lazy-loads the bizops module, so that it's only instantiated when the consuming function is used. This felt like a simple way of doing it without changing too much - happier to hear better options though.