chore(NA): splits types from code on @kbn/rule-data-utils (elastic#121535)

* chore(NA): splits types from code on @kbn/rule-data-utils

* chore(NA): remove old style imports for this pkg

* chore(NA): eslint fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Author: mistic

.eslintrc.js

@@ -850,10 +850,6 @@ module.exports = {
                 name: 'semver',
                 message: 'Please use "semver/*/{function}" instead',
               },
-              {
-                name: '@kbn/rule-data-utils',
-                message: `Import directly from @kbn/rule-data-utils/* submodules in public/common code`,
-              },
             ],
           },
         ],

package.json

@@ -581,6 +581,7 @@
     "@types/kbn__plugin-generator": "link:bazel-bin/packages/kbn-plugin-generator/npm_module_types",
     "@types/kbn__plugin-helpers": "link:bazel-bin/packages/kbn-plugin-helpers/npm_module_types",
     "@types/kbn__react-field": "link:bazel-bin/packages/kbn-react-field/npm_module_types",
+    "@types/kbn__rule-data-utils": "link:bazel-bin/packages/kbn-rule-data-utils/npm_module_types",
     "@types/license-checker": "15.0.0",
     "@types/listr": "^0.14.0",
     "@types/loader-utils": "^1.1.3",

packages/BUILD.bazel

@@ -99,6 +99,7 @@ filegroup(
       "//packages/kbn-plugin-generator:build_types",
       "//packages/kbn-plugin-helpers:build_types",
       "//packages/kbn-react-field:build_types",
+      "//packages/kbn-rule-data-utils:build_types",
   ],
 )
 

packages/kbn-rule-data-utils/BUILD.bazel

@@ -1,9 +1,10 @@
-load("@npm//@bazel/typescript:index.bzl", "ts_config", "ts_project")
-load("@build_bazel_rules_nodejs//:index.bzl", "js_library", "pkg_npm")
-load("//src/dev/bazel:index.bzl", "jsts_transpiler")
+load("@npm//@bazel/typescript:index.bzl", "ts_config")
+load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
+load("//src/dev/bazel:index.bzl", "jsts_transpiler", "pkg_npm", "pkg_npm_types", "ts_project")
 
 PKG_BASE_NAME = "kbn-rule-data-utils"
 PKG_REQUIRE_NAME = "@kbn/rule-data-utils"
+TYPES_PKG_REQUIRE_NAME = "@types/kbn__rule-data-utils"
 
 SOURCE_FILES = glob(
   [
@@ -20,10 +21,6 @@ filegroup(
 
 NPM_MODULE_EXTRA_FILES = [
   "package.json",
-  "alerts_as_data_rbac/package.json",
-  "alerts_as_data_severity/package.json",
-  "alerts_as_data_status/package.json",
-  "technical_field_names/package.json",
 ]
 
 RUNTIME_DEPS = [
@@ -75,7 +72,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = RUNTIME_DEPS + [":target_node", ":tsc_types"],
+  deps = RUNTIME_DEPS + [":target_node"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )
@@ -94,3 +91,20 @@ filegroup(
   ],
   visibility = ["//visibility:public"],
 )
+
+pkg_npm_types(
+  name = "npm_module_types",
+  srcs = SRCS,
+  deps = [":tsc_types"],
+  package_name = TYPES_PKG_REQUIRE_NAME,
+  tsconfig = ":tsconfig",
+  visibility = ["//visibility:public"],
+)
+
+filegroup(
+  name = "build_types",
+  srcs = [
+    ":npm_module_types",
+  ],
+  visibility = ["//visibility:public"],
+)

packages/kbn-rule-data-utils/alerts_as_data_rbac/package.json

@@ -1,7 +1,6 @@
 {
   "name": "@kbn/rule-data-utils",
   "main": "./target_node/index.js",
-  "types": "./target_types/index.d.ts",
   "version": "1.0.0",
   "license": "SSPL-1.0 OR Elastic License 2.0",
   "private": true

packages/kbn-rule-data-utils/alerts_as_data_severity/package.json

@@ -12,7 +12,7 @@ import {
   ALERT_EVALUATION_THRESHOLD,
   ALERT_EVALUATION_VALUE,
   ALERT_SEVERITY,
-} from '@kbn/rule-data-utils/technical_field_names';
+} from '@kbn/rule-data-utils';
 import type { ObservabilityRuleTypeRegistry } from '../../../../observability/public';
 import { ENVIRONMENT_ALL } from '../../../common/environment_filter_values';
 import {

packages/kbn-rule-data-utils/alerts_as_data_status/package.json

@@ -16,7 +16,7 @@ import {
 } from '@elastic/charts';
 import { EuiTitle } from '@elastic/eui';
 import React, { Suspense, useState } from 'react';
-import { ALERT_RULE_TYPE_ID } from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_RULE_TYPE_ID } from '@kbn/rule-data-utils';
 import { i18n } from '@kbn/i18n';
 import { useApmServiceContext } from '../../../../context/apm_service/use_apm_service_context';
 import { APIReturnType } from '../../../../services/rest/createCallApmApi';

packages/kbn-rule-data-utils/package.json

@@ -16,13 +16,13 @@ import {
   ALERT_SEVERITY,
   ALERT_START,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   ALERT_UUID,
   SPACE_IDS,
   ALERT_RULE_UUID,
   ALERT_RULE_NAME,
   ALERT_RULE_CATEGORY,
-} from '@kbn/rule-data-utils/technical_field_names';
-import { ALERT_STATUS_ACTIVE } from '@kbn/rule-data-utils/alerts_as_data_status';
+} from '@kbn/rule-data-utils';
 import { ValuesType } from 'utility-types';
 import { EuiTheme } from '../../../../../../../../src/plugins/kibana_react/common';
 import { ObservabilityRuleTypeRegistry } from '../../../../../../observability/public';

packages/kbn-rule-data-utils/technical_field_names/package.json

@@ -19,7 +19,7 @@ import {
   ALERT_UUID,
   ALERT_RULE_TYPE_ID,
   ALERT_RULE_NAME,
-} from '@kbn/rule-data-utils/technical_field_names';
+} from '@kbn/rule-data-utils';
 import React, { Dispatch, SetStateAction } from 'react';
 import { EuiTheme } from 'src/plugins/kibana_react/common';
 import { ValuesType } from 'utility-types';

x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts

@@ -9,7 +9,7 @@ import { EuiFlexGroup, EuiFlexItem, EuiSelect, EuiTitle } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import React from 'react';
 import { useHistory } from 'react-router-dom';
-import { ALERT_RULE_TYPE_ID } from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_RULE_TYPE_ID } from '@kbn/rule-data-utils';
 import { AlertType } from '../../../../../common/alert_types';
 import { useApmServiceContext } from '../../../../context/apm_service/use_apm_service_context';
 import { LatencyAggregationType } from '../../../../../common/latency_aggregation_types';

x-pack/plugins/apm/public/components/app/error_group_details/Distribution/index.tsx

@@ -14,6 +14,7 @@ import {
   ALERT_SEVERITY,
   ALERT_START,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   ALERT_UUID,
   TIMESTAMP,
   ALERT_RULE_UUID,
@@ -22,8 +23,7 @@ import {
   ALERT_RULE_CONSUMER,
   ALERT_RULE_PRODUCER,
   SPACE_IDS,
-} from '@kbn/rule-data-utils/technical_field_names';
-import { ALERT_STATUS_ACTIVE } from '@kbn/rule-data-utils/alerts_as_data_status';
+} from '@kbn/rule-data-utils';
 import { Meta, Story } from '@storybook/react';
 import React from 'react';
 import { MemoryRouter } from 'react-router-dom';

x-pack/plugins/apm/public/components/shared/charts/helper/get_alert_annotations.test.tsx

@@ -11,7 +11,7 @@ import {
   ALERT_EVALUATION_THRESHOLD,
   ALERT_EVALUATION_VALUE,
   ALERT_REASON,
-} from '@kbn/rule-data-utils/technical_field_names';
+} from '@kbn/rule-data-utils';
 import { createLifecycleRuleTypeFactory } from '../../../../rule_registry/server';
 import {
   ENVIRONMENT_NOT_DEFINED,

x-pack/plugins/apm/public/components/shared/charts/helper/get_alert_annotations.tsx

@@ -11,7 +11,7 @@ import {
   ALERT_EVALUATION_THRESHOLD,
   ALERT_EVALUATION_VALUE,
   ALERT_REASON,
-} from '@kbn/rule-data-utils/technical_field_names';
+} from '@kbn/rule-data-utils';
 import { take } from 'rxjs/operators';
 import { asDuration } from '../../../../observability/common/utils/formatters';
 import { createLifecycleRuleTypeFactory } from '../../../../rule_registry/server';

x-pack/plugins/apm/public/components/shared/charts/latency_chart/index.tsx

@@ -14,7 +14,7 @@ import {
   ALERT_EVALUATION_VALUE,
   ALERT_SEVERITY,
   ALERT_REASON,
-} from '@kbn/rule-data-utils/technical_field_names';
+} from '@kbn/rule-data-utils';
 import { createLifecycleRuleTypeFactory } from '../../../../rule_registry/server';
 import { ProcessorEvent } from '../../../common/processor_event';
 import { getSeverity } from '../../../common/anomaly_detection';

x-pack/plugins/apm/public/components/shared/charts/latency_chart/latency_chart.stories.tsx

@@ -11,7 +11,7 @@ import {
   ALERT_EVALUATION_THRESHOLD,
   ALERT_EVALUATION_VALUE,
   ALERT_REASON,
-} from '@kbn/rule-data-utils/technical_field_names';
+} from '@kbn/rule-data-utils';
 import {
   ENVIRONMENT_NOT_DEFINED,
   getEnvironmentEsField,

x-pack/plugins/apm/server/routes/alerts/register_error_count_alert_type.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { EVENT_KIND } from '@kbn/rule-data-utils/technical_field_names';
+import { EVENT_KIND } from '@kbn/rule-data-utils';
 import { IRuleDataClient } from '../../../../rule_registry/server';
 import {
   SERVICE_NAME,

x-pack/plugins/apm/server/routes/alerts/register_transaction_duration_alert_type.ts

@@ -12,7 +12,7 @@ import {
   EuiCommentList,
   EuiCommentProps,
 } from '@elastic/eui';
-import { ALERT_RULE_NAME, ALERT_RULE_UUID } from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_RULE_NAME, ALERT_RULE_UUID } from '@kbn/rule-data-utils';
 
 import classNames from 'classnames';
 import { get, isEmpty } from 'lodash';

x-pack/plugins/apm/server/routes/alerts/register_transaction_duration_anomaly_alert_type.ts

@@ -5,11 +5,7 @@
  * 2.0.
  */
 
-import {
-  ALERT_REASON,
-  ALERT_RULE_PARAMETERS,
-  TIMESTAMP,
-} from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_REASON, ALERT_RULE_PARAMETERS, TIMESTAMP } from '@kbn/rule-data-utils';
 import { encode } from 'rison-node';
 import { stringify } from 'query-string';
 import { ObservabilityRuleTypeFormatter } from '../../../../observability/public';

x-pack/plugins/apm/server/routes/alerts/register_transaction_error_rate_alert_type.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { ALERT_REASON, ALERT_START } from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_REASON, ALERT_START } from '@kbn/rule-data-utils';
 import { modifyUrl } from '@kbn/std';
 import { ObservabilityRuleTypeFormatter } from '../../../../observability/public';
 

x-pack/plugins/apm/server/routes/services/get_service_alerts.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { ALERT_REASON } from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_REASON } from '@kbn/rule-data-utils';
 import { ObservabilityRuleTypeFormatter } from '../../../../observability/public';
 
 export const formatReason: ObservabilityRuleTypeFormatter = ({ fields }) => {

x-pack/plugins/cases/public/components/user_action_tree/index.tsx

@@ -7,10 +7,7 @@
 import * as t from 'io-ts';
 
 export type Maybe<T> = T | null | undefined;
-import {
-  ALERT_STATUS_ACTIVE,
-  ALERT_STATUS_RECOVERED,
-} from '@kbn/rule-data-utils/alerts_as_data_status';
+import { ALERT_STATUS_ACTIVE, ALERT_STATUS_RECOVERED } from '@kbn/rule-data-utils';
 
 export const alertWorkflowStatusRt = t.keyof({
   open: null,

x-pack/plugins/infra/public/alerting/inventory/rule_data_formatters.ts

@@ -8,7 +8,7 @@
 import React from 'react';
 import { i18n } from '@kbn/i18n';
 import { EuiHealth, EuiText } from '@elastic/eui';
-import { ALERT_STATUS_ACTIVE, AlertStatus } from '@kbn/rule-data-utils/alerts_as_data_status';
+import { ALERT_STATUS_ACTIVE, AlertStatus } from '@kbn/rule-data-utils';
 import { useTheme } from '../../hooks/use_theme';
 
 interface AlertStatusIndicatorProps {

x-pack/plugins/infra/public/alerting/log_threshold/rule_data_formatters.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { ALERT_UUID } from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_UUID } from '@kbn/rule-data-utils';
 import React, { ComponentType } from 'react';
 import { KibanaContextProvider } from '../../../../../../../../src/plugins/kibana_react/public';
 import { PluginContext, PluginContextValue } from '../../../../context/plugin_context';

x-pack/plugins/infra/public/alerting/metric_threshold/rule_data_formatters.ts

@@ -28,11 +28,9 @@ import {
   ALERT_UUID,
   ALERT_RULE_CATEGORY,
   ALERT_RULE_NAME,
-} from '@kbn/rule-data-utils/technical_field_names';
-import {
   ALERT_STATUS_ACTIVE,
   ALERT_STATUS_RECOVERED,
-} from '@kbn/rule-data-utils/alerts_as_data_status';
+} from '@kbn/rule-data-utils';
 import moment from 'moment-timezone';
 import React, { useMemo } from 'react';
 import type { TopAlert } from '../../containers';

x-pack/plugins/observability/common/typings.ts

@@ -18,11 +18,9 @@ import {
   ALERT_RULE_NAME,
   ALERT_RULE_CATEGORY,
   ALERT_RULE_PRODUCER,
-} from '@kbn/rule-data-utils/technical_field_names';
-import {
   ALERT_STATUS_ACTIVE,
   ALERT_STATUS_RECOVERED,
-} from '@kbn/rule-data-utils/alerts_as_data_status';
+} from '@kbn/rule-data-utils';
 
 export const apmAlertResponseExample = [
   {

x-pack/plugins/observability/public/components/shared/alert_status_indicator.tsx

@@ -8,11 +8,7 @@
 import { EuiButtonGroup, EuiButtonGroupOptionProps } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import React from 'react';
-import {
-  ALERT_STATUS_ACTIVE,
-  ALERT_STATUS_RECOVERED,
-} from '@kbn/rule-data-utils/alerts_as_data_status';
-import { ALERT_STATUS } from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_STATUS_ACTIVE, ALERT_STATUS_RECOVERED, ALERT_STATUS } from '@kbn/rule-data-utils';
 import { AlertStatusFilterButton } from '../../../../common/typings';
 import { AlertStatusFilter } from '../../../../common/typings';
 

x-pack/plugins/observability/public/pages/alerts/components/alerts_flyout/alerts_flyout.stories.tsx

@@ -8,10 +8,10 @@
 import {
   ALERT_START,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   ALERT_RULE_TYPE_ID,
   ALERT_RULE_NAME,
-} from '@kbn/rule-data-utils/technical_field_names';
-import { ALERT_STATUS_ACTIVE } from '@kbn/rule-data-utils/alerts_as_data_status';
+} from '@kbn/rule-data-utils';
 import type { TopAlert } from '../';
 import { experimentalRuleFieldMap } from '../../../../../rule_registry/common/assets/field_maps/experimental_rule_field_map';
 import { parseTechnicalFields } from '../../../../../rule_registry/common/parse_technical_fields';

x-pack/plugins/observability/public/pages/alerts/components/alerts_flyout/alerts_flyout.tsx

@@ -5,11 +5,7 @@
  * 2.0.
  */
 
-import {
-  ALERT_STATUS_ACTIVE,
-  ALERT_STATUS_RECOVERED,
-} from '@kbn/rule-data-utils/alerts_as_data_status';
-import { ALERT_STATUS } from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_STATUS, ALERT_STATUS_ACTIVE, ALERT_STATUS_RECOVERED } from '@kbn/rule-data-utils';
 import type { CellValueElementProps } from '../../../../../../timelines/common';
 import { createObservabilityRuleTypeRegistryMock } from '../../../../rules/observability_rule_type_registry_mock';
 import * as PluginHook from '../../../../hooks/use_plugin_context';

x-pack/plugins/observability/public/pages/alerts/components/alerts_flyout/example_data.ts

@@ -10,13 +10,11 @@ import {
   ALERT_DURATION,
   ALERT_SEVERITY,
   ALERT_STATUS,
-  ALERT_REASON,
-  TIMESTAMP,
-} from '@kbn/rule-data-utils/technical_field_names';
-import {
   ALERT_STATUS_ACTIVE,
   ALERT_STATUS_RECOVERED,
-} from '@kbn/rule-data-utils/alerts_as_data_status';
+  ALERT_REASON,
+  TIMESTAMP,
+} from '@kbn/rule-data-utils';
 import type { CellValueElementProps, TimelineNonEcsData } from '../../../../../../timelines/common';
 import { AlertStatusIndicator } from '../../../../components/shared/alert_status_indicator';
 import { TimestampTooltip } from '../../../../components/shared/timestamp_tooltip';

x-pack/plugins/observability/public/pages/alerts/components/alerts_status_filter.tsx

@@ -11,8 +11,7 @@ import { IndexPatternBase } from '@kbn/es-query';
 import { i18n } from '@kbn/i18n';
 import React, { useCallback, useEffect, useRef, useState } from 'react';
 import useAsync from 'react-use/lib/useAsync';
-import { AlertStatus } from '@kbn/rule-data-utils/alerts_as_data_status';
-import { ALERT_STATUS } from '@kbn/rule-data-utils/technical_field_names';
+import { ALERT_STATUS, AlertStatus } from '@kbn/rule-data-utils';
 
 import { euiStyled } from '../../../../../../../../src/plugins/kibana_react/common';
 import { loadAlertAggregations as loadRuleAggregations } from '../../../../../../../plugins/triggers_actions_ui/public';