Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): splits types from code on @kbn/rule-data-utils #121535

Merged
merged 6 commits into from
Dec 20, 2021
Merged

chore(NA): splits types from code on @kbn/rule-data-utils #121535

merged 6 commits into from
Dec 20, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 17, 2021

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Dec 17, 2021
@mistic mistic requested a review from jbudz December 17, 2021 14:57
@mistic mistic marked this pull request as ready for review December 17, 2021 18:28
@mistic mistic requested review from a team as code owners December 17, 2021 18:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Dec 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@mistic
Copy link
Member Author

mistic commented Dec 20, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1216 1218 +2
cases 361 365 +4
infra 918 922 +4
observability 340 342 +2
uptime 661 664 +3
total +15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB -9.2KB
cases 307.2KB 309.2KB +2.0KB
infra 987.2KB 995.2KB +8.0KB
observability 359.9KB 352.0KB -7.9KB
securitySolution 4.6MB 4.6MB -2.0KB
timelines 227.0KB 225.0KB -2.0KB
uptime 675.6KB 675.6KB +7.0B
total -11.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
kibana 897 898 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 29.0KB 31.0KB +2.0KB
securitySolution 241.5KB 243.5KB +2.0KB
timelines 134.7KB 136.7KB +2.0KB
uptime 23.0KB 24.8KB +1.8KB
total +7.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Dec 20, 2021

I'm going ahead and merge this PR as this is mainly a package build layout change. Let me know if you have further feedback

@mistic mistic merged commit aa6fe69 into elastic:main Dec 20, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 20, 2021
mibragimov pushed a commit to mibragimov/kibana that referenced this pull request Dec 22, 2021
@mistic @kibanamachine
chore(NA): splits types from code on @kbn/rule-data-utils (elastic#12…
518d347 
…1535)

* chore(NA): splits types from code on @kbn/rule-data-utils

* chore(NA): remove old style imports for this pkg

* chore(NA): eslint fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonhultgren miltonhultgren

@jbudz jbudz

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Operations Team label for Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mistic @elasticmachine @kibana-ci @miltonhultgren @jbudz @kibanamachine