Skip to content

Commit ce2f617

Browse files
[Security Solutions] Removes POC transforms (elastic#129673)
## Summary Removes the `metrics_entities` plugin and POC. As a different direction will be taken and people can look back at the git history for it as they see fit if they need to refer to it. Once it's re-added it it will be through an RFC process and re-discussed. Earlier PR's which added the POC: elastic#96446 elastic#104559 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
1 parent 268470a commit ce2f617

File tree

189 files changed

+117
-7545
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

189 files changed

+117
-7545
lines changed

.eslintrc.js

-126
Original file line numberDiff line numberDiff line change
@@ -1242,132 +1242,6 @@ module.exports = {
12421242
},
12431243
},
12441244

1245-
/**
1246-
* Metrics entities overrides. These rules below are maintained and owned by
1247-
* the people within the security-solution-platform team. Please see ping them
1248-
* or check with them if you are encountering issues, have suggestions, or would
1249-
* like to add, change, or remove any particular rule. Linters, Typescript, and rules
1250-
* evolve and change over time just like coding styles, so please do not hesitate to
1251-
* reach out.
1252-
*/
1253-
{
1254-
// front end and common typescript and javascript files only
1255-
files: [
1256-
'x-pack/plugins/metrics_entities/public/**/*.{js,mjs,ts,tsx}',
1257-
'x-pack/plugins/metrics_entities/common/**/*.{js,mjs,ts,tsx}',
1258-
],
1259-
rules: {
1260-
'import/no-nodejs-modules': 'error',
1261-
'no-restricted-imports': [
1262-
'error',
1263-
{
1264-
// prevents UI code from importing server side code and then webpack including it when doing builds
1265-
patterns: ['**/server/*'],
1266-
},
1267-
],
1268-
},
1269-
},
1270-
{
1271-
// typescript and javascript for front and back end
1272-
files: ['x-pack/plugins/metrics_entities/**/*.{js,mjs,ts,tsx}'],
1273-
plugins: ['eslint-plugin-node'],
1274-
env: {
1275-
jest: true,
1276-
},
1277-
rules: {
1278-
'accessor-pairs': 'error',
1279-
'array-callback-return': 'error',
1280-
'no-array-constructor': 'error',
1281-
complexity: 'error',
1282-
'consistent-return': 'error',
1283-
'func-style': ['error', 'expression'],
1284-
'import/order': [
1285-
'error',
1286-
{
1287-
groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
1288-
'newlines-between': 'always',
1289-
},
1290-
],
1291-
'sort-imports': [
1292-
'error',
1293-
{
1294-
ignoreDeclarationSort: true,
1295-
},
1296-
],
1297-
'node/no-deprecated-api': 'error',
1298-
'no-bitwise': 'error',
1299-
'no-continue': 'error',
1300-
'no-dupe-keys': 'error',
1301-
'no-duplicate-case': 'error',
1302-
'no-duplicate-imports': 'error',
1303-
'no-empty-character-class': 'error',
1304-
'no-empty-pattern': 'error',
1305-
'no-ex-assign': 'error',
1306-
'no-extend-native': 'error',
1307-
'no-extra-bind': 'error',
1308-
'no-extra-boolean-cast': 'error',
1309-
'no-extra-label': 'error',
1310-
'no-func-assign': 'error',
1311-
'no-implicit-globals': 'error',
1312-
'no-implied-eval': 'error',
1313-
'no-invalid-regexp': 'error',
1314-
'no-inner-declarations': 'error',
1315-
'no-lone-blocks': 'error',
1316-
'no-multi-assign': 'error',
1317-
'no-misleading-character-class': 'error',
1318-
'no-new-symbol': 'error',
1319-
'no-obj-calls': 'error',
1320-
'no-param-reassign': ['error', { props: true }],
1321-
'no-process-exit': 'error',
1322-
'no-prototype-builtins': 'error',
1323-
'no-return-await': 'error',
1324-
'no-self-compare': 'error',
1325-
'no-shadow-restricted-names': 'error',
1326-
'no-sparse-arrays': 'error',
1327-
'no-this-before-super': 'error',
1328-
// rely on typescript
1329-
'no-undef': 'off',
1330-
'no-unreachable': 'error',
1331-
'no-unsafe-finally': 'error',
1332-
'no-useless-call': 'error',
1333-
'no-useless-catch': 'error',
1334-
'no-useless-concat': 'error',
1335-
'no-useless-computed-key': 'error',
1336-
'no-useless-escape': 'error',
1337-
'no-useless-rename': 'error',
1338-
'no-useless-return': 'error',
1339-
'no-void': 'error',
1340-
'one-var-declaration-per-line': 'error',
1341-
'prefer-object-spread': 'error',
1342-
'prefer-promise-reject-errors': 'error',
1343-
'prefer-rest-params': 'error',
1344-
'prefer-spread': 'error',
1345-
'prefer-template': 'error',
1346-
'require-atomic-updates': 'error',
1347-
'symbol-description': 'error',
1348-
'vars-on-top': 'error',
1349-
'@typescript-eslint/explicit-member-accessibility': 'error',
1350-
'@typescript-eslint/no-this-alias': 'error',
1351-
'@typescript-eslint/no-explicit-any': 'error',
1352-
'@typescript-eslint/no-useless-constructor': 'error',
1353-
'@typescript-eslint/unified-signatures': 'error',
1354-
'@typescript-eslint/explicit-function-return-type': 'error',
1355-
'@typescript-eslint/no-non-null-assertion': 'error',
1356-
'@typescript-eslint/no-unused-vars': 'error',
1357-
'no-template-curly-in-string': 'error',
1358-
'sort-keys': 'error',
1359-
'prefer-destructuring': 'error',
1360-
'no-restricted-imports': [
1361-
'error',
1362-
{
1363-
// prevents code from importing files that contain the name "legacy" within their name. This is a mechanism
1364-
// to help deprecation and prevent accidental re-use/continued use of code we plan on removing. If you are
1365-
// finding yourself turning this off a lot for "new code" consider renaming the file and functions if it has valid uses.
1366-
patterns: ['*legacy*'],
1367-
},
1368-
],
1369-
},
1370-
},
13711245
/**
13721246
* Alerting Services overrides
13731247
*/

.github/CODEOWNERS

-1
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,6 @@
394394
/x-pack/test/plugin_functional/plugins/resolver_test/ @elastic/security-solution
395395
/x-pack/test/plugin_functional/test_suites/resolver/ @elastic/security-solution
396396
/x-pack/plugins/security_solution/ @elastic/security-solution
397-
/x-pack/plugins/metrics_entities/ @elastic/security-solution
398397
/x-pack/test/detection_engine_api_integration @elastic/security-solution
399398
/x-pack/test/lists_api_integration @elastic/security-solution
400399
/x-pack/test/api_integration/apis/security_solution @elastic/security-solution

docs/developer/plugin-list.asciidoc

-6
Original file line numberDiff line numberDiff line change
@@ -524,12 +524,6 @@ using the CURL scripts in the scripts folder.
524524
|Visualize geo data from Elasticsearch or 3rd party geo-services.
525525
526526
527-
|{kib-repo}blob/{branch}/x-pack/plugins/metrics_entities/README.md[metricsEntities]
528-
|This is the metrics and entities plugin where you add can add transforms for your project
529-
and group those transforms into modules. You can also re-use existing transforms in your
530-
newly created modules as well.
531-
532-
533527
|{kib-repo}blob/{branch}/x-pack/plugins/ml/readme.md[ml]
534528
|This plugin provides access to the machine learning features provided by
535529
Elastic.

packages/kbn-cli-dev-mode/src/get_server_watch_paths.test.ts

-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ it('produces the right watch and ignore list', () => {
7676
<absolute path>/x-pack/plugins/lists/server/scripts,
7777
<absolute path>/x-pack/plugins/security_solution/scripts,
7878
<absolute path>/x-pack/plugins/security_solution/server/lib/detection_engine/scripts,
79-
<absolute path>/x-pack/plugins/metrics_entities/server/scripts,
8079
<absolute path>/x-pack/plugins/uptime/e2e,
8180
]
8281
`);

packages/kbn-cli-dev-mode/src/get_server_watch_paths.ts

-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ export function getServerWatchPaths({ pluginPaths, pluginScanDirs }: Options) {
6666
fromRoot('x-pack/plugins/lists/server/scripts'),
6767
fromRoot('x-pack/plugins/security_solution/scripts'),
6868
fromRoot('x-pack/plugins/security_solution/server/lib/detection_engine/scripts'),
69-
fromRoot('x-pack/plugins/metrics_entities/server/scripts'),
7069
fromRoot('x-pack/plugins/uptime/e2e'),
7170
];
7271

x-pack/.i18nrc.json

-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
"xpack.logstash": ["plugins/logstash"],
3939
"xpack.main": "legacy/plugins/xpack_main",
4040
"xpack.maps": ["plugins/maps"],
41-
"xpack.metricsEntities": "plugins/metrics_entities",
4241
"xpack.ml": ["plugins/ml"],
4342
"xpack.monitoring": ["plugins/monitoring"],
4443
"xpack.osquery": ["plugins/osquery"],

0 commit comments

Comments
 (0)