-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solutions] Removes POC transforms #129673
[Security Solutions] Removes POC transforms #129673
Conversation
…into remove-transform
I probably have not been involved in some conversations but I'm wondering why not just amend the code as we flesh out features for this rather than pull it all out now? Is there detriment in keeping it in the code base for now? If there have been conversations around just re-building from the ground up and this is the approach I think that is fair but I was just wondering if there are any discussions I missed around pulling this out of the codebase now? |
@dhurley14, It's been in the codebase for almost a year with no traction. Since I'm departing, I don't think I should leave behind code that would be difficult for another engineer to remove at this point vs. the other way which is an engineer can re-invent the code or copy the code back if need be. This feature requires a RFC and probably a re-think and renewed ownership. The code can be found in the git history if needed. It would de-activate in several instances and is hard to explain to people how metrics and entities work generally. Looking at our roadmap this performance improvement honestly doesn't look like it is ever going to be a priority vs. other features? I'm just pointing out that maybe the business is ok with the performance of the application as it is today. If this is not going to be a priority for another year or ever and probably never worked on again why keep it in the codebase was my thinking. I mean, at this point it's up to you, @yctercero, and @peluja1012 if you want to keep it in here or not. |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with everyone and agreed on general direction of relying on git history when the time comes to implementing metrics entities etc. LGTM.
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Removes the
metrics_entities
plugin and POC. As a different direction will be taken and people can look back at the git history for it as they see fit if they need to refer to it. Once it's re-added it it will be through an RFC process and re-discussed.Earlier PR's which added the POC:
#96446
#104559
Checklist