Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Adds Background primitive component #564

Merged
merged 9 commits into from
May 14, 2020
Merged

Adds Background primitive component #564

merged 9 commits into from
May 14, 2020

Conversation

maddles
Copy link
Contributor

@maddles maddles commented May 11, 2020 •
edited
Loading

This PR makes the new simple component usable in Victory Native. Changes included:

  • Added a NativeBackground component to render the react-native-svg circle and chart by default
  • Pass the NativeBackground component as the default prop for backgroundComponent on VictoryChart
  • Import DefinitelyTyped defs from victory-core

Simulator Screen Shot - iPhone 11 - 2020-05-14 at 23 32 46

@maddles maddles requested a review from wsparsons May 11, 2020 23:24
@maddles maddles requested a review from boygirl May 14, 2020 22:53
@maddles maddles changed the title WIP - adds Background primitive component Adds Background primitive component May 14, 2020
@maddles maddles marked this pull request as ready for review May 14, 2020 23:03
@boygirl
Copy link
Contributor

boygirl commented May 14, 2020

@maddles I had to add victory-histogram to the dependencies in the demo package.json to get this to run, but that's expected until after we publish a new version of victory-native. All the changes look good. Approved!

@boygirl boygirl merged commit 9389aaf into master May 14, 2020
@boygirl boygirl deleted the task/add-chart-background branch May 14, 2020 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boygirl boygirl boygirl approved these changes

@wsparsons wsparsons Awaiting requested review from wsparsons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maddles @boygirl