-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve german translation for ethos and ethos suite #5229
base: 1.6
Are you sure you want to change the base?
Conversation
Have you tested these translations on all transmitters? Some of your translations are longer than the old ones. There are transmitters, that have a smaller display. In the past there was a lot of work put in, to reduce the length of the translation, so they are readable on transmitters with smaller displays as well. I fear you have tested them only on transmitters with bigger displays. German translations tend to be much longer than the English original. I strongly recommend to test, the translations on every display size |
The new CSV system allows different text displayed, depending on the radio:
I think that this possibility is very interesting for Deutsch (and French too!) |
I agree, thats a nice possibility But as far as I see the changes are for all transmitters at the moment. Therefore the question if these changes got verified on all transmitters. |
Please give a few examples. |
I think this line won't work: |
In case it is needed, the CSV can be tested with the simulator directly. |
…h X20S and X14S simulator
What's wrong with that? |
Nothing. I just wanted to show that this specific line actually does work.
I just modified the de.csv for use with "All other radios". Unfortunately the X10EXPRESS simulator uses the X20-strings instead of the strings for "All other radios". An example would be:
|
I know that it works like this. I have just looked through the menu items and found 4 more changes. I will implement them, but they will probably not take effect until the next Ethos version. |
The X10 Express is not any more supported by Ethos 1.6 |
Ok I understand. But do strings for "All other radios" actually work? Or are they ignored? |
You may test with X18 / X18S / Twin XLite |
The third possible translation string for "All other radios" works with Twin X Lite S simulator. I have just tested all modifications with the X20S, X18R, X14S and TWXLITES simulators. I'd be very happy if this is merged. |
Wolepo maintains this file. I need his approval before pushing the button. He may push it as well! |
Will be done tomorrow. |
Thank you! |
@Wolepo For example: Or here two strings from the current version: I can find at least 20 more of these inconsistencies. This really makes Ethos look like an unfinished version of an RC operating system. And this despite the fact that it is actually an excellent system in the backend! |
??? |
Hello, I wonder where you get your de.csv from. What you mention here is wrong. |
You may test the translations online now and on all Ethos radios: |
You may even give a CSV as parameter to the page, like this: |
Thanks a lot! That's a great enhancement. I'll definitely give it a try later. |
I think I can improve further. Give me an extra day :) |
Improved german translation for Ethos firmware [1.6.2] and Ethos Suite [1.6.1].