Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve german translation for ethos and ethos suite #5229

Open
wants to merge 5 commits into
base: 1.6
Choose a base branch
from

Conversation

martinwilco
Copy link

Improved german translation for Ethos firmware [1.6.2] and Ethos Suite [1.6.1].

@Dsrenger
Copy link

Have you tested these translations on all transmitters?

Some of your translations are longer than the old ones.

There are transmitters, that have a smaller display.

In the past there was a lot of work put in, to reduce the length of the translation, so they are readable on transmitters with smaller displays as well.

I fear you have tested them only on transmitters with bigger displays.

German translations tend to be much longer than the English original.

I strongly recommend to test, the translations on every display size

@bsongis
Copy link
Contributor

bsongis commented Mar 11, 2025

The new CSV system allows different text displayed, depending on the radio:

String name, String context, X20(...) / XE(S) / V20, X18RS / X14(...) / T14 / V15, All other radios

I think that this possibility is very interesting for Deutsch (and French too!)

@Dsrenger
Copy link

Dsrenger commented Mar 11, 2025

I agree, thats a nice possibility

But as far as I see the changes are for all transmitters at the moment. Therefore the question if these changes got verified on all transmitters.
before this question is not answered I wouldnt merge it.

@Wolepo
Copy link
Collaborator

Wolepo commented Mar 11, 2025

Please give a few examples.

@bsongis
Copy link
Contributor

bsongis commented Mar 11, 2025

I think this line won't work:
GYRO_CALIBRATION_LEFT,,"Zur LINKEN Seite neigen. Dann "Weiter" drücken."

@bsongis
Copy link
Contributor

bsongis commented Mar 11, 2025

In case it is needed, the CSV can be tested with the simulator directly.

@martinwilco
Copy link
Author

I have now tested everything with the X20S and the X14S simulator. For some strings I added modifications for the smaller displays.

I think this line won't work: GYRO_CALIBRATION_LEFT,,"Zur LINKEN Seite neigen. Dann "Weiter" drücken."

image
Thats's from the X14S simulator.

@Wolepo
Copy link
Collaborator

Wolepo commented Mar 11, 2025

What's wrong with that?

@martinwilco
Copy link
Author

martinwilco commented Mar 11, 2025

What's wrong with that?

Nothing. I just wanted to show that this specific line actually does work.

The new CSV system allows different text displayed, depending on the radio:

String name, String context, X20(...) / XE(S) / V20, X18RS / X14(...) / T14 / V15, All other radios

I think that this possibility is very interesting for Deutsch (and French too!)

I just modified the de.csv for use with "All other radios". Unfortunately the X10EXPRESS simulator uses the X20-strings instead of the strings for "All other radios". An example would be:

TRAINER,,"L/S-Konfiguration","L/S-Konfig.","L/S-Konfig."

image

@Wolepo
Copy link
Collaborator

Wolepo commented Mar 11, 2025

I know that it works like this. I have just looked through the menu items and found 4 more changes. I will implement them, but they will probably not take effect until the next Ethos version.

@bsongis
Copy link
Contributor

bsongis commented Mar 12, 2025

The X10 Express is not any more supported by Ethos 1.6
It doesn't have such a feature.

@martinwilco
Copy link
Author

Ok I understand. But do strings for "All other radios" actually work? Or are they ignored?

@bsongis
Copy link
Contributor

bsongis commented Mar 12, 2025

You may test with X18 / X18S / Twin XLite

@martinwilco
Copy link
Author

The third possible translation string for "All other radios" works with Twin X Lite S simulator. I have just tested all modifications with the X20S, X18R, X14S and TWXLITES simulators. I'd be very happy if this is merged.

@bsongis
Copy link
Contributor

bsongis commented Mar 12, 2025

Wolepo maintains this file. I need his approval before pushing the button. He may push it as well!

@bsongis
Copy link
Contributor

bsongis commented Mar 12, 2025

@Wolepo

@Wolepo
Copy link
Collaborator

Wolepo commented Mar 12, 2025

Will be done tomorrow.

@martinwilco
Copy link
Author

Thank you!
I would be very happy if you could merge the translation file for the Ethos Suite as well.

@martinwilco
Copy link
Author

@Wolepo
I really don't understand what happened with the translation file updates. There are a few things wrong now that were correct in my file.
Above all, there are now some new inconsistencies.

For example:
My pr:
ADD_EXTRA_TRIM,,"Extra-Trimmung hinzufügen","Extra-Trimmung hinz." EXTRA_TRIM,,"Extra-Trimmung"
Now:
ADD_EXTRA_TRIM,,"Extra Trimmer hinzufügen","Extra-Trimmung hinz." EXTRA_TRIM,,"Extra trim"
Why suddenly have different translations for "TRIM"??

Or here two strings from the current version:
NO_TIMER_HINT,,"Keine Stoppuhr eingestellt. Zum Erstellen Plus-Button drücken!","Zum Erstellen einer Stoppuhr Plus Button drücken"
NO_MIX_HINT,,"Kein Mischer vorhanden. Plus-Button drücken zum Erstellen!","Zum Erstellen eines Mischers Plus-Button drücken"
Why change the word order? What's the reason? And why "Plus-Button" AND "Plus Button"? Why not just one consistent and clear version?

I can find at least 20 more of these inconsistencies.
I think this makes it particularly difficult for new users to understand Ethos. It's not intuitive as a result.
I'm also quite disappointed that my attempt to make everything clearer and easier to understand has been partially worsened.

This really makes Ethos look like an unfinished version of an RC operating system. And this despite the fact that it is actually an excellent system in the backend!

@bsongis
Copy link
Contributor

bsongis commented Mar 19, 2025

???

@Wolepo
Copy link
Collaborator

Wolepo commented Mar 19, 2025

Hello, I wonder where you get your de.csv from. What you mention here is wrong.
Changes in the wording are necessary because of the smaller displays in order to remain understandable. Random abbreviations have the opposite effect.
Insert the attached de.csv in the simulator, e.g. in C:\Users\Username.ethos\X14S\translations. Now start the simulator.
de.csv

@martinwilco
Copy link
Author

I just had a look at the file you provided and checked it with the X14S and X20S simulator.
And voilà there are exactly the inconsistencies I described.

For example (your de.csv in X14S simulator):
image
image
That's exactly what I meant. Why would you write "Plus-Button" in the first one and "Plus Button" in the second one. Why is the "!" missing in the second one?

Another example (your de.csv in X20S simulator):
image
image
Why would you change the word order in the second sentence?
Please either put "Plus-Button drücken zum Erstellen" OR "Zum Erstellen Plus-Button drücken", but not a mix of both:)

These are just two examples of many...
Everything was right in the file that I uploaded.
Just have a look at the "Resove conflicts" function here in the chat. You will find many more changes like that.

@bsongis-frsky
Copy link
Collaborator

You may test the translations online now and on all Ethos radios:
https://ethos.studio1247.com/

@bsongis-frsky
Copy link
Collaborator

Example of translations difference, using the online simulator:

image

@martinwilco
Copy link
Author

Thanks a lot! That's a great enhancement. I'll definitely give it a try later.

@bsongis
Copy link
Contributor

bsongis commented Mar 20, 2025

I think I can improve further. Give me an extra day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants