Remove babel requirement for server

[ylecuyer]

Remove babel requirement for server files

[jung-kim]

I'm okay with removing babel but this means ungit will not work on older node or older browser as some of the client code within /components is in es6 now.

It would be nice to make a note of this in readme.

[ylecuyer]

I may be wrong but the components assets are already served as es6. If I look at http://localhost:8448/plugins/app/app.bundle.js for example, I can see a fat arrow here :

    this.repoList.subscribe((newValue) => { storage.setItem('repositories', JSON.stringify(newValue)); });

And the grunt file calls browserify-components directly inside ./components which are not fed into babel (only source)

[campersau]

It looks like @ylecuyer is right, the components were never fed into babel.
And since all tests passed on node 8 I think it is good.

I know its been a long time but do you mind rebasing this PR or creating a new one?
Otherwise I can do that for you.

[Hirse]

Proposal:
Keep babel, but use it with preset-env for both server and components with different targets (and possibly "compile" shared files twice). This might end up being a no-op for Node, but that way we can use latest JS features and don't have to worry about support.

Side note, what are the supported browsers? I am getting syntax errors in IE11 from the fat arrows.

[campersau]

Its been over a year since #1137 got merged and we never got any issues regarding that.
So I would vote for just supporting evergreen browsers and make the build process a bit simpler :)

[campersau]

Thanks @ylecuyer !

---

If we still want to support older browsers we could use https://github.com/babel/babelify for example.

It is a bit difficult because octicons switched to a newer syntax and browserify ignores npm_modules by default and we use Array.prototype.includes, String.prototype.includes for which we would need a polyfill.