Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and Use Latest Octicons #1224

Merged
merged 5 commits into from
Oct 30, 2019
Merged

Update and Use Latest Octicons #1224

merged 5 commits into from
Oct 30, 2019

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Oct 21, 2019

This builds on #1223 but with the latest version of Octicons.
With that version the icons are used as SVG instead of fonts.
(Credit to @exsilium for the work in exsilium#4.)

  • All changes from Use consistent icons in dropdown #1223
  • Use latest version of Octicons
  • Changed icons
    • Use verified instead of key for PGP signatures (as GitHub does)
    • Use skip instead of i to add files to ignore (avoid confusion from i being used for "information")
    • Use globe instead of broadcast for "remote" consistently (as it was already the case for tags)
  • Switch + and x to octicons consistently (from glyphicons and unicode)
  • Use octicons for refresh button and align design with other buttons
  • Use actual <button> for ignore and discard files in staging
  • Fix all semicolon and quote mark lint violations in changed files

Copy link
Collaborator

@campersau campersau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more icon font 👍

@campersau campersau merged commit 502e3f0 into FredrikNoren:master Oct 30, 2019
@Hirse Hirse deleted the octicon-svg branch October 30, 2019 17:31
@campersau campersau mentioned this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants