Fix electron package #1240
Merged
Fix electron package #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campersau
commented
Nov 3, 2019
| - git config --global user.email "test@testy.com" | ||
| - git config --global user.name "Test testy" | ||
| - git version | ||
| - npm run build | ||
| after_success: | ||
| - DISPLAY= npm run package |
There was a problem hiding this comment.
This took me 1 1/2 days to find out 🤦♂
Merged
campersau
force-pushed
the
electron-package
branch
from
c944a7e to
4078933
Compare
campersau
force-pushed
the
electron-package
branch
from
4078933 to
74c5724
Compare
|
@campersau I'm unable to use copy and paste when using electron app, is it intended? |
|
@aitboudad can you please open a new issue? |
|
done #1251 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use latest electron packager and build them in CI.
fixes #593 for the second time :)