Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify logging level to info to match kedro's one #348

Closed
Galileo-Galilei opened this issue Aug 24, 2022 · 0 comments · Fixed by #354
Closed

Modify logging level to info to match kedro's one #348

Galileo-Galilei opened this issue Aug 24, 2022 · 0 comments · Fixed by #354
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Galileo-Galilei
Copy link
Owner

Description

The default logging level in kedro has changed (see kedro-org/kedro#1732) to "warning" in kedro==0.18.2 to match python's default, and kedro-mflow logs are not displayed anymore

Context

Logging messages are useful to understand what kedro-mlflow does under the hood.

Possible Implementation

Use after_context_created hook to modify logging configuration.

Possible Alternatives

  • Alternative 1: Ask users to add
loggers:
    kedro:
        level: INFO
    <my_package>:
        level: INFO
    kedro-mlflow:
        level: INFO

in their logging.yml file. This does not seem very user friendly.

  • Alternative 2: Set all logger to "warning" to make them visible again. This does look unnecessary scary for users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant