Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata parameters to kedro-mlflow datasets #625

Closed
gtauzin opened this issue Feb 7, 2025 · 3 comments · Fixed by #633
Closed

Add metadata parameters to kedro-mlflow datasets #625

gtauzin opened this issue Feb 7, 2025 · 3 comments · Fixed by #633
Assignees
Labels
enhancement New feature or request

Comments

@gtauzin
Copy link
Contributor

gtauzin commented Feb 7, 2025

Hi,
First of all, thanks a lot for this amazing plugin!

Description

It seems that kedro assumes its datasets can all take a metadata parameters. In previous versions of the kedro doc, I remember reading that metadata was meant to be exploited by orchestration-related kedro plugins, I could not find this statement anymore on the latest doc.

However, there is now a hook documented that aims at showing how to access metadata: https://docs.kedro.org/en/stable/hooks/common_use_cases.html#use-hooks-to-read-metadata-from-datacatalog

Context

I am developing a kedro plugin for the dagster orchestrator: https://github.com/gtauzin/kedro-dagster and I would like to be able to associate metadata to kedro-mlflow datasets. I make use of the metadata arguments of datasets to display a description or other metadata on the Dagster UI.

@gtauzin
Copy link
Contributor Author

gtauzin commented Feb 8, 2025

BTW, if this is as straightforward as it seems, I am happy to open a PR :)

@Galileo-Galilei
Copy link
Owner

Hi Guillaume, I'd love to have this, feel free to open PRs!

Btw I think it should already be ok for MLflowArtifactDataset because it fakes inheritance and preserves attributes of the underlying dataset.

@Galileo-Galilei Galileo-Galilei moved this from 🆕 New to 🔖 Ready in kedro-mlflow roadmap Feb 9, 2025
@Galileo-Galilei Galileo-Galilei added the enhancement New feature or request label Feb 9, 2025
@gtauzin
Copy link
Contributor Author

gtauzin commented Feb 10, 2025

Perfect @Galileo-Galilei, I will get started very soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants