Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all datasets to take a metadata parameter #633

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

gtauzin
Copy link
Contributor

@gtauzin gtauzin commented Feb 14, 2025

Description

Fixes #625.
Make all kedro-mlflow datasets take a metadata parameter, thus aligning with kedro datasets.

Development notes

Added a metadata parameters to all datasets and tested that it is properly set and it does not appear when dataset._describe is called.

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Signed-off-by: Guillaume Tauzin <4648633+gtauzin@users.noreply.github.com>
@Galileo-Galilei
Copy link
Owner

It seems good to go, thanks for the PR!

Feel free to ping this week once you have merge master back, so I'll merge it immediately.

@gtauzin
Copy link
Contributor Author

gtauzin commented Feb 17, 2025

@Galileo-Galilei I have fixed the conflict but snyk is complaining. I don't know the tool but I can't see the security issue so I requested access.

@Galileo-Galilei
Copy link
Owner

Thank you very much, I'll release it soon.

Don't worry about snyk, basically it doesn't like that I don't pin very recent kedro and mlflow versions because of known exploits in old versions. I certainly won't because it breaks retrocompatibility. Whatever I do, it even complains about the recent versions of kedro an mlflow so I can't do much to please it. I mainly keep to get alerts in case of critical CVEs.

@Galileo-Galilei Galileo-Galilei merged commit 85fc3fd into Galileo-Galilei:master Feb 17, 2025
1 of 2 checks passed
@gtauzin gtauzin deleted the dataset_metadata branch February 17, 2025 10:03
@gtauzin
Copy link
Contributor Author

gtauzin commented Feb 17, 2025

@Galileo-Galilei Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add metadata parameters to kedro-mlflow datasets
2 participants