Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enable passing kwargs to create_experiment from configuration, including artifact_location (#557) #641

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Feb 18, 2025

Description

Close #557

Development notes

  • add a configuration option for create_experiment_kwargs in KedroMLflowConfig and mlflow.yml
  • update KedroMLflowConfig.setup() to manually create the eperiment instead of delegating it to mlflow.set_experiment()
  • (UNRELATED) Replace all Dict[str,Any] |None introduced by Enable all datasets to take a metadata parameter #633 by Optional[dict[str,any]] to ensure compatiblity with python 3.9
  • (UNRELATED) Replace all Dict and List from typing by native dict and list

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei linked an issue Feb 18, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.44%. Comparing base (023049b) to head (9a856d3).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
- Coverage   99.90%   99.44%   -0.47%     
==========================================
  Files          30       28       -2     
  Lines        1054     1073      +19     
==========================================
+ Hits         1053     1067      +14     
- Misses          1        6       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Galileo-Galilei Galileo-Galilei force-pushed the 557-support-passing-artifact_uri-in-config branch from 2169de9 to 5dc0947 Compare February 18, 2025 20:42
@Galileo-Galilei Galileo-Galilei merged commit b0d68f6 into master Feb 18, 2025
5 of 6 checks passed
@Galileo-Galilei Galileo-Galilei deleted the 557-support-passing-artifact_uri-in-config branch February 18, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Support passing artifact_uri in config
2 participants