Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #159 - Refactor CLI to make mlflow.yml read and write more flexible to different configuration logic #162

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Feb 7, 2021

Description

Fix #159

Development notes

  • Remove dynamic apparition of project CLI commands. They are now always displayed even if the project is not initialised yet.
  • Remove _aready_updated function which is no longer used, since no check is made to verify that the projec tis initialized
  • Add a env argument to kedro mlflow init to enable to create the configuration in another ocation than "base"
  • Remove the possibility to call kedro mlflow ui outside of the project (this is not a breaking change: this code was not usable until now since the command did not display outside of a project)
  • Add an extra check in get_mlflow_config to inform the user if the project is not initialised yet.
  • The mlflow.yml is now created by default in conf/local instead of conf/base

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei force-pushed the feature/dynamic-configloader-path branch from bb8eb76 to a345e26 Compare February 7, 2021 21:01
@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review February 7, 2021 21:02
@codecov-io
Copy link

codecov-io commented Feb 7, 2021

Codecov Report

Merging #162 (a345e26) into develop (ef3b0e2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          770       758   -12     
=========================================
- Hits           770       758   -12     
Impacted Files Coverage Δ
kedro_mlflow/utils.py 100.00% <ø> (ø)
tests/test_utils.py 100.00% <ø> (ø)
kedro_mlflow/framework/cli/cli.py 100.00% <100.00%> (ø)
kedro_mlflow/framework/context/mlflow_context.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef3b0e2...a345e26. Read the comment docs.

@Galileo-Galilei Galileo-Galilei merged commit 5d5b6fe into develop Feb 15, 2021
@Galileo-Galilei Galileo-Galilei deleted the feature/dynamic-configloader-path branch February 15, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the mlflow.yml location dependent of the ConfigLoader configuration
2 participants