Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/use default mtu #325

Merged
merged 3 commits into from
May 31, 2022
Merged

Feat/use default mtu #325

merged 3 commits into from
May 31, 2022

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented May 31, 2022

Description

Close #321

Development notes

  • Update kedro requirements to kedro>=0.18.1 which was incorrectly set to kedro>=0.18.0
  • Change template to set server.mlflow_tracking_uri: null as a default in mlflow.yml
  • Change KedroMlflowConfig behaviour: mlflow_tracking_uri retrieves the MLFLOW_TRACKING_URI environment variable if the server.mlflow_tracking_uri argument is None.

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei
Copy link
Owner Author

Galileo-Galilei commented May 31, 2022

The PR is failing because of this: ipython/traitlets#739. A fix was released 12 mn ago (!), but it still a pre-release on PyPI.

@JanB1
Copy link

JanB1 commented May 31, 2022

@Galileo-Galilei Newest version of traitlets is 5.2.2.post1 which implemented the fix. See https://pypi.org/project/traitlets/5.2.2.post1/.

@Galileo-Galilei
Copy link
Owner Author

Thank you very much for the fast fix and reply @JanB1 !

@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review May 31, 2022 22:10
@Galileo-Galilei Galileo-Galilei merged commit b52dc82 into master May 31, 2022
@Galileo-Galilei Galileo-Galilei deleted the feat/use-default-mtu branch May 31, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use MLFLOW_TRACKING_URI environment variable by default instead of mlruns
2 participants