Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Stop logging a success init message when init fails (#336) #339

Merged
merged 1 commit into from
Jul 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixed

- :bug: Make ``pipeline_ml_factory`` now correctly uses ``kpm_kwargs`` and ``log_model_kwargs`` instead of always using the default values. ([#329](https://github.com/Galileo-Galilei/kedro-mlflow/issues/329))
- :bug: ``kedro mlflow init`` command no longer raises both a success and an error message when the command is failing. ([#336](https://github.com/Galileo-Galilei/kedro-mlflow/issues/336))

### Changed

Expand Down
14 changes: 7 additions & 7 deletions kedro_mlflow/framework/cli/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,20 +106,20 @@ def init(env: str, force: bool, silent: bool):
dst=mlflow_yml_path,
python_package=project_metadata.package_name,
)
if not silent:
click.secho(
click.style(
f"'{settings.CONF_SOURCE}/{env}/{mlflow_yml}' successfully updated.",
fg="green",
)
)
except FileNotFoundError:
click.secho(
click.style(
f"No env '{env}' found. Please check this folder exists inside '{settings.CONF_SOURCE}' folder.",
fg="red",
)
)
if not silent:
click.secho(
click.style(
f"'{settings.CONF_SOURCE}/{env}/{mlflow_yml}' successfully updated.",
fg="green",
)
)


@mlflow_commands.command()
Expand Down